Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing unused import #814

Merged
merged 2 commits into from
Jan 14, 2024
Merged

Removing unused import #814

merged 2 commits into from
Jan 14, 2024

Conversation

siddtheone
Copy link
Contributor

Checklist

  • I have ensured my pull request is not behind the main or master branch of the original repository.
  • I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first.
  • I have written a commit message that passes commitlint linting.
  • I have ensured that my code changes pass linting tests.
  • I have ensured that my code changes pass unit tests.
  • I have described my pull request and the reasons for code changes along with context if necessary.

@rimiti
Copy link
Contributor

rimiti commented Jan 25, 2023

Hello @siddtheone ,

Thank your for your contribution but this import is use into below examples:
https://github.com/ladjs/supertest/blob/master/README.md?plain=1#L152

I close this issue.

Have a nice day, 👋

@siddtheone
Copy link
Contributor Author

siddtheone commented Jan 25, 2023

Hello @siddtheone ,

Thank your for your contribution but this import is use into below examples: https://github.com/ladjs/supertest/blob/master/README.md?plain=1#L152

I close this issue.

Have a nice day, 👋
It's not being used in the first snippet which says
https://github.com/ladjs/supertest/blob/master/README.md?plain=1#L32

I also think we can just replace
assert(response.body.email, 'foo@bar.com')
with
expect(response.body.email).toEqual('foo@bar.com')

Like https://github.com/ladjs/supertest/blob/master/README.md?plain=1#L168

Copy link
Contributor

@lamweili lamweili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@titanism titanism merged commit 6b41374 into ladjs:master Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants