Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: agent cookie host assignment #1809

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

robaca
Copy link

@robaca robaca commented Jul 3, 2024

Checklist

  • I have ensured my pull request is not behind the main or master branch of the original repository.
  • I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first.
  • I have written a commit message that passes commitlint linting.
  • I have ensured that my code changes pass linting tests.
  • I have ensured that my code changes pass unit tests.
    • multipart tests are green
  • I have described my pull request and the reasons for code changes along with context if necessary in ticket 1807

@welecomtopython
Copy link

`` @
Uploading check-list-icon.png…

@robaca
Copy link
Author

robaca commented Sep 10, 2024

What's preventing a merge here?

The multipart tests (which should not relate to my fix) are not working but as you can see here, they are not even causing a failing CI pipeline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants