fix: updating thicknesses will update value constraints value

previously, wasn't updating causing odd geometries

Author: lachlangrose

LoopStructural/modelling/input/process_data.py

@@ -469,41 +469,42 @@ def _update_feature_names(self, dataframe):
 
     @property
     def contacts(self):
-        return self._contacts
-
-    @contacts.setter
-    def contacts(self, contacts):
-        """Function to convert input contact to loopstructural input
-
-        either uses the thickness values or assigns unique ids given
-        the units named in stratigraphic order
-
-        Returns
-        -------
-        DataFrame
-            data frame with x,y,y,val/interface,feature_name
-        """
-        if contacts is None:
-            return
-        contacts = contacts.copy()
-        self._update_feature_names(contacts)
+        contacts = self._contacts.copy()
         if self._use_thickness:
             contacts["val"] = np.nan
             for k, v in self._stratigraphic_value().items():
                 contacts.loc[contacts["name"] == k, "val"] = v
 
-            self._contacts = contacts.loc[
+            contacts = contacts.loc[
                 ~np.isnan(contacts["val"]), ["X", "Y", "Z", "feature_name", "val"]
             ]
         if not self._use_thickness:
             contacts["interface"] = np.nan
             interface_val = 0
             for k in self._stratigraphic_value().keys():
                 contacts.loc[contacts["name"] == k, "interface"] = interface_val
-            self._contacts = contacts.loc[
+            contacts = contacts.loc[
                 ~np.isnan(contacts["interface"]),
                 ["X", "Y", "Z", "feature_name", "interface"],
             ]
+        return contacts
+
+    @contacts.setter
+    def contacts(self, contacts):
+        """Function to convert input contact to loopstructural input
+
+        either uses the thickness values or assigns unique ids given
+        the units named in stratigraphic order
+
+        Returns
+        -------
+        DataFrame
+            data frame with x,y,y,val/interface,feature_name
+        """
+        if contacts is None:
+            return
+        self._contacts = contacts.copy()
+        self._update_feature_names(self._contacts)
 
     @property
     def contact_orientations(self):