fix: adding 3D fault displacement function

Author: lachlangrose

LoopStructural/modelling/features/builders/_fault_builder.py

@@ -134,9 +134,15 @@ def create_data_from_geometry(
             logger.warning(f"Fault major axis using map length: {major_axis}")
 
         if minor_axis is None:
+            logger.info(
+                f"Fault minor axis not set, using half major axis: {major_axis/2}"
+            )
             minor_axis = major_axis / 2.0
         if intermediate_axis is None:
             intermediate_axis = major_axis
+            logger.info(
+                f"Fault intermediate axis not set, using major axis: {intermediate_axis}"
+            )
         self.fault_minor_axis = minor_axis
         self.fault_major_axis = major_axis
         self.fault_intermediate_axis = intermediate_axis

LoopStructural/modelling/features/fault/_fault_function.py

@@ -186,3 +186,41 @@ class BaseFault(object):
     gzf.add_max(1)
     gxf = Composite(hw, fw)
     fault_displacement = FaultDisplacement(gx=gxf, gy=gyf, gz=gzf)
+
+
+class BaseFault3D(object):
+    """ """
+
+    hw = CubicFunction()
+    hw.add_cstr(0, 1)
+    hw.add_grad(0, 0)
+    hw.add_cstr(1, 0)
+    # hw.add_cstr(1,1)
+
+    hw.add_grad(1, 0)
+    hw.add_max(1)
+    fw = CubicFunction()
+    fw.add_cstr(0, -1)
+    fw.add_grad(0, 0)
+    fw.add_cstr(-1, 0)
+    fw.add_grad(-1, 0)
+    fw.add_min(-1)
+    gyf = CubicFunction()
+    gyf.add_cstr(-1, 0)
+    gyf.add_cstr(1, 0)
+    gyf.add_cstr(-0.2, 1)
+    gyf.add_cstr(0.2, 1)
+    gyf.add_grad(0, 0)
+    gyf.add_min(-1)
+    gyf.add_max(1)
+    # gyf = Ones()
+    gzf = CubicFunction()
+    gzf.add_cstr(-1, 0)
+    gzf.add_cstr(1, 0)
+    gzf.add_cstr(-0.2, 1)
+    gzf.add_cstr(0.2, 1)
+    gzf.add_grad(0, 0)
+    gzf.add_min(-1)
+    gzf.add_max(1)
+    gxf = Composite(hw, fw)
+    fault_displacement = FaultDisplacement(gx=gxf, gy=gyf, gz=gzf)

LoopStructural/modelling/features/fault/_fault_segment.py

@@ -2,7 +2,7 @@
     FaultDisplacementFeature,
 )
 from ....modelling.features import FeatureType
-from ....modelling.features.fault._fault_function import BaseFault
+from ....modelling.features.fault._fault_function import BaseFault, BaseFault3D
 from ....utils import getLogger, NegativeRegion, PositiveRegion
 from ....modelling.features import StructuralFrame
 
@@ -57,6 +57,8 @@ def faultfunction(self, value):
             self._faultfunction = value
         elif isinstance(value, str) and value == "BaseFault":
             self._faultfunction = BaseFault.fault_displacement
+        elif isinstance(value, str) and value == "BaseFault3D":
+            self._faultfunction = BaseFault3D.fault_displacement
         else:
             raise ValueError("Fault function must be a function or BaseFault")