Skip to content

Commit 0d05ebc

Browse files
committed
todo
1 parent 46e9edf commit 0d05ebc

File tree

4 files changed

+29
-3
lines changed

4 files changed

+29
-3
lines changed

LoopStructural/api/model.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
def CreateModelWithSingleScalarField():
2+
pass
3+
4+
5+
def AddFaultToModel():
6+
pass

LoopStructural/interpolators/_geological_interpolator.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,6 @@ def set_tangent_constraints(self, points: np.ndarray):
141141
self.up_to_date = False
142142

143143
def set_interface_constraints(self, points: np.ndarray):
144-
145144
self.data["interface"] = points
146145
self.up_to_date = False
147146

@@ -209,6 +208,12 @@ def get_interface_constraints(self):
209208
def get_inequality_constraints(self):
210209
return self.data["inequality"]
211210

211+
def setup(self, **kwargs):
212+
"""
213+
Runs all of the required setting up stuff
214+
"""
215+
self._setup_interpolator(**kwargs)
216+
212217
def setup_interpolator(self, **kwargs):
213218
"""
214219
Runs all of the required setting up stuff

LoopStructural/modelling/core/geological_model.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -693,6 +693,7 @@ def set_stratigraphic_column(self, stratigraphic_column, cmap="tab20"):
693693

694694
self.stratigraphic_column = stratigraphic_column
695695

696+
## TODO CREATE SEPARATE API FOR THIS
696697
def get_interpolator(
697698
self,
698699
interpolatortype="FDI",
@@ -817,7 +818,6 @@ def get_interpolator(
817818
)
818819
return P2Interpolator(mesh)
819820
if interpolatortype == "FDI":
820-
821821
# find the volume of one element
822822
if element_volume is None:
823823
element_volume = box_vol / nelements
@@ -1648,7 +1648,6 @@ def create_and_add_fault(
16481648
points=kwargs.get("points", False),
16491649
)
16501650
if "force_mesh_geometry" not in kwargs:
1651-
16521651
fault_frame_builder.set_mesh_geometry(kwargs.get("fault_buffer", 0.2), 0)
16531652
if "splay" in kwargs and "splayregion" in kwargs:
16541653
fault_frame_builder.add_splay(kwargs["splay"], kwargs["splayregion"])
@@ -1669,6 +1668,7 @@ def create_and_add_fault(
16691668

16701669
return fault
16711670

1671+
# TODO move rescale to bounding box/transformer
16721672
def rescale(self, points: np.ndarray, inplace: bool = True) -> np.ndarray:
16731673
"""
16741674
Convert from model scale to real world scale - in the future this
@@ -1691,6 +1691,7 @@ def rescale(self, points: np.ndarray, inplace: bool = True) -> np.ndarray:
16911691
points += self.origin
16921692
return points
16931693

1694+
# TODO move scale to bounding box/transformer
16941695
def scale(self, points: np.ndarray, inplace: bool = True) -> np.ndarray:
16951696
"""Take points in UTM coordinates and reproject
16961697
into scaled model space
Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
# Todo list for LoopStructural
2+
3+
1. Create interpolation API
4+
- use scikit learn style
5+
- allow interpolation to be used within scikit learn pipeline
6+
- generic api for all interpolators
7+
- 2D/3D
8+
9+
2. Modelling API
10+
- create api for using GeologicalModel class
11+
-
12+
13+
14+
3.

0 commit comments

Comments
 (0)