Skip to content

Enable custom request id generator #881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 17, 2017
Merged

Enable custom request id generator #881

merged 1 commit into from
Mar 17, 2017

Conversation

nownabe
Copy link
Contributor

@nownabe nownabe commented Mar 17, 2017

Hi! ☀️

I couldn't use a custom ID generator for RequestID middleware and fixed!

@coveralls
Copy link

coveralls commented Mar 17, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.1%) to 84.077% when pulling 6dca623 on nownabe:fix_request_id_middleware into b2430fc on labstack:master.

@vishr vishr merged commit cb6f0a5 into labstack:master Mar 17, 2017
@vishr
Copy link
Member

vishr commented Mar 17, 2017

@nownabe Thanks for your contribution 🎉

@nownabe
Copy link
Contributor Author

nownabe commented Mar 18, 2017

@vishr Thank you!! 😄 ✨

@nownabe nownabe deleted the fix_request_id_middleware branch March 18, 2017 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nownabe @coveralls @vishr