Skip to content

Fix case when routeNotFound handler is lost when new route is added to the router #2219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 13, 2022

Conversation

aldas
Copy link
Contributor

@aldas aldas commented Jul 12, 2022

Fix case when routeNotFound handler is lost when new route is added to the router.

This happens when new handler we are registering has shorter and partially matching path as router node with routeNotFound handler. In that case when we split existing node into 2 parts we need to assign routeNotFound handler also to split node.

@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

Merging #2219 (4425059) into master (690e339) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2219   +/-   ##
=======================================
  Coverage   92.33%   92.34%           
=======================================
  Files          37       37           
  Lines        3118     3122    +4     
=======================================
+ Hits         2879     2883    +4     
  Misses        150      150           
  Partials       89       89           
Impacted Files Coverage Δ
router.go 96.74% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 690e339...4425059. Read the comment docs.

@aldas aldas merged commit 70acd57 into labstack:master Jul 13, 2022
@aldas aldas deleted the fix_routenotfound_splitting branch December 29, 2022 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant