Skip to content

Commit 6d4864a

Browse files
committed
Fixed router tests
Signed-off-by: Vishal Rana <vr@labstack.com>
1 parent b9eec15 commit 6d4864a

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

router.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -307,8 +307,9 @@ func (r *Router) ServeHTTP(w http.ResponseWriter, req *http.Request) {
307307
h, _ := r.Find(req.Method, req.URL.Path, c)
308308
c.reset(req, w, r.echo)
309309
if h == nil {
310-
h = r.echo.notFoundHandler
310+
c.Error(NewHTTPError(http.StatusNotFound))
311+
} else {
312+
h(c)
311313
}
312-
h(c)
313314
r.echo.pool.Put(c)
314315
}

router_test.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -531,11 +531,13 @@ func TestRouterServeHTTP(t *testing.T) {
531531
req, _ := http.NewRequest(GET, "/users", nil)
532532
w := httptest.NewRecorder()
533533
r.ServeHTTP(w, req)
534+
assert.Equal(t, http.StatusOK, w.Code)
534535

535536
// Not found
536537
req, _ = http.NewRequest(GET, "/files", nil)
537538
w = httptest.NewRecorder()
538539
r.ServeHTTP(w, req)
540+
assert.Equal(t, http.StatusNotFound, w.Code)
539541
}
540542

541543
func (n *node) printTree(pfx string, tail bool) {

0 commit comments

Comments
 (0)