Skip to content

Commit 282a44d

Browse files
im-kulikovvishr
authored andcommitted
Remove unreachable code (#1254)
`if` <-> `else if` <-> `else` has `return` and after `else` was `return`
1 parent 0b714f3 commit 282a44d

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

bind.go

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -47,21 +47,17 @@ func (b *DefaultBinder) Bind(i interface{}, c Context) (err error) {
4747
return NewHTTPError(http.StatusBadRequest, fmt.Sprintf("Unmarshal type error: expected=%v, got=%v, field=%v, offset=%v", ute.Type, ute.Value, ute.Field, ute.Offset)).SetInternal(err)
4848
} else if se, ok := err.(*json.SyntaxError); ok {
4949
return NewHTTPError(http.StatusBadRequest, fmt.Sprintf("Syntax error: offset=%v, error=%v", se.Offset, se.Error())).SetInternal(err)
50-
} else {
51-
return NewHTTPError(http.StatusBadRequest, err.Error()).SetInternal(err)
5250
}
53-
return NewHTTPError(http.StatusBadRequest, err.Error())
51+
return NewHTTPError(http.StatusBadRequest, err.Error()).SetInternal(err)
5452
}
5553
case strings.HasPrefix(ctype, MIMEApplicationXML), strings.HasPrefix(ctype, MIMETextXML):
5654
if err = xml.NewDecoder(req.Body).Decode(i); err != nil {
5755
if ute, ok := err.(*xml.UnsupportedTypeError); ok {
5856
return NewHTTPError(http.StatusBadRequest, fmt.Sprintf("Unsupported type error: type=%v, error=%v", ute.Type, ute.Error())).SetInternal(err)
5957
} else if se, ok := err.(*xml.SyntaxError); ok {
6058
return NewHTTPError(http.StatusBadRequest, fmt.Sprintf("Syntax error: line=%v, error=%v", se.Line, se.Error())).SetInternal(err)
61-
} else {
62-
return NewHTTPError(http.StatusBadRequest, err.Error()).SetInternal(err)
6359
}
64-
return NewHTTPError(http.StatusBadRequest, err.Error())
60+
return NewHTTPError(http.StatusBadRequest, err.Error()).SetInternal(err)
6561
}
6662
case strings.HasPrefix(ctype, MIMEApplicationForm), strings.HasPrefix(ctype, MIMEMultipartForm):
6763
params, err := c.FormParams()

0 commit comments

Comments
 (0)