Skip to content

Commit 23dcd29

Browse files
committed
Do not set content-type on empty content for compress middleware
1 parent 2647a0f commit 23dcd29

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

middleware/compress.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ func GzipWithConfig(config GzipConfig) echo.MiddlewareFunc {
8080
w.Reset(rw)
8181
grw := &gzipResponseWriter{Writer: w, ResponseWriter: rw}
8282
defer func() {
83-
if !grw.wroteBody {
83+
if !grw.wroteBody || res.Size == 0 {
8484
if res.Header().Get(echo.HeaderContentEncoding) == gzipScheme {
8585
res.Header().Del(echo.HeaderContentEncoding)
8686
}

middleware/compress_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ func TestGzipEmpty(t *testing.T) {
114114
return c.String(http.StatusOK, "")
115115
})
116116
if assert.NoError(t, h(c)) {
117-
assert.Equal(t, gzipScheme, rec.Header().Get(echo.HeaderContentEncoding))
117+
assert.Empty(t, rec.Header().Get(echo.HeaderContentEncoding))
118118
assert.Equal(t, "text/plain; charset=UTF-8", rec.Header().Get(echo.HeaderContentType))
119119
r, err := gzip.NewReader(rec.Body)
120120
if assert.NoError(t, err) {

0 commit comments

Comments
 (0)