Add support for Pico 2 (RP2350) #30
Merged
+216
−130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dihm
approved these changes
Apr 9, 2025
There was a problem hiding this comment.
Finally got some initial testing done here. I can confirm that both a Pico1 and 2 work with this build of the firmware in a basic test.
While it would be nice to apply a more thorough test, I don't really have time for a full battery to confirm specs ATM. I am confident enough to merge and release (after minor comments are at least looked at) and deal with more thorough tests later.
… time from the SDK so it is kept up to date
When built for the Pico 2, we now support: - 60,000 instructions - Clock speeds up to 150 MHz - Running on PIO2 We've also: - Added new `board` command that returns the board version (either `pico1` or `pico2`) - Dynamically computed array sizes - bumped the version to v1.2.0 - Refactored the cmake file to be a lot cleaner and support building for more than one board. The maximum number of instructions is now defined here - Bumped the pico SDK version to v2.0.0 - Fixed a bug with Ubuntu 24.04 that broke the apt-mirror override in the docker container - Updated the docker compose container for simultaneous build of firmware for multiple boards (in a way that doesn't cause long docker build times). This is also following the best practices outlined by the pico-sdk that encourages you to separate build dirs for different boards to avoid conflicts with cached cmake configuration.
Also manually install picotool from source to ensure its version matches the sdk version (and doesn't have to be rebuilt by each firmware build). This was necessary to bump pico-sdk to 2.1.1
dihm
force-pushed
the
philipstarkey/rp235x
branch
from
8796dd5 to
ace5ee6
Compare
|
I've gone ahead and fixed my two comments and bumped the SDK to 2.1.1. Both Pico1 and 2 are nominally functional built under this version of the SDK. More rigorous testing would be nice, but I'm happy to merge as-is and save the testing for later when we allow for the RP2040 to get to 200MHz (which should be a separate PR). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When built for the Pico 2, we now support:
We've also:
boardcommand that returns the board version (eitherpico1orpico2)pico_sdk_import.cmakefrom the repo so it can be kept up-to-date with the version in the pico-sdk.