Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Use ansible package instead of ansible apt for heterogeneous environment #16

Merged
merged 3 commits into from
Aug 26, 2023

Conversation

thunderysteak
Copy link
Contributor

@thunderysteak thunderysteak commented Jun 5, 2023

Description

On a Rocky system, the playbook fails due of usage of ansible.builtin.apt instead of ansible.builtin.package

TASK [Install iptables-persistent] *********************************************
[WARNING]: Updating cache and auto-installing missing dependency: python3-apt
fatal: [bastion]: FAILED! => {"changed": false, "cmd": "apt-get update", "msg": "[Errno 2] No such file or directory: b'apt-get': b'apt-get'", "rc": 2, "stderr": "", "stderr_lines": [], "stdout": "", "stdout_lines": []}

Additionally, iptables-persistent is only for Debian family and iptables-services is for Redhat family

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Small minor change not affecting the Ansible Collection/Role code (Github Actions Workflow, Documentation etc.)

How Has This Been Tested?

Local testing using Vagrant against Rocky Linux 8 host
Main playbook has completed successfully.

Unable to test with Molecule due to issues with ansible/molecule#2755

Copy link
Collaborator

@MonolithProjects MonolithProjects left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@MonolithProjects MonolithProjects added the bug Something isn't working label Aug 26, 2023
@MonolithProjects MonolithProjects merged commit ac07ae1 into lablabs:main Aug 26, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants