Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an id property, this new property will be used as unique to in… #1750

Merged
merged 3 commits into from
Sep 22, 2023
Merged

Create an id property, this new property will be used as unique to in… #1750

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
faae6c0
Create an id property, this new property will be used as unique to in…
dlascarez Sep 18, 2023
4276da6
Apply suggestions
dlascarez Sep 18, 2023
f4a5598
Adding if to validate if user send or no the list of columns
dlascarez Sep 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "angular-datatables",
"version": "16.0.0",
"version": "16.0.1",
shanmukhateja marked this conversation as resolved.
Show resolved Hide resolved
"description": "Angular directive for DataTables",
"scripts": {
"build": "npm run clean && npm run compile && npm run bundles && npm run schematics:build",
Expand Down
8 changes: 6 additions & 2 deletions src/angular-datatables.directive.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,10 @@ export class DataTableDirective implements OnDestroy, OnInit {
reject('Both the table and dtOptions cannot be empty');
return;
}

// Set a column unique
resolvedDTOptions.columns.forEach((col: ADTColumns, i: number) => col.id = i);
shanmukhateja marked this conversation as resolved.
Show resolved Hide resolved

// Using setTimeout as a "hack" to be "part" of NgZone
setTimeout(() => {
// Assign DT properties here
Expand Down Expand Up @@ -108,7 +112,7 @@ export class DataTableDirective implements OnDestroy, OnInit {
const pipe = el.ngPipeInstance;
const pipeArgs = el.ngPipeArgs || [];
// find index of column using `data` attr
const i = columns.filter(c => c.visible !== false).findIndex(e => e.data === el.data);
const i = columns.filter(c => c.visible !== false).findIndex(e => e.id === el.id);
// get <td> element which holds data using index
const rowFromCol = row.childNodes.item(i);
// Transform data with Pipe and PipeArgs
Expand All @@ -125,7 +129,7 @@ export class DataTableDirective implements OnDestroy, OnInit {
colsWithTemplate.forEach(el => {
const { ref, context } = el.ngTemplateRef;
// get <td> element which holds data using index
const i = columns.filter(c => c.visible !== false).findIndex(e => e.data === el.data);
const i = columns.filter(c => c.visible !== false).findIndex(e => e.id === el.id);
const cellFromIndex = row.childNodes.item(i);
// reset cell before applying transform
$(cellFromIndex).html('');
Expand Down
2 changes: 2 additions & 0 deletions src/models/settings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ export interface ADTSettings extends DataTables.Settings {
columns?: ADTColumns[];
}
export interface ADTColumns extends DataTables.ColumnSettings {
/** Define a column index */
shanmukhateja marked this conversation as resolved.
Show resolved Hide resolved
id?: number;
shanmukhateja marked this conversation as resolved.
Show resolved Hide resolved
/** Set instance of Angular pipe to transform the data of particular column */
ngPipeInstance?: PipeTransform;
/** Define the arguments for the tranform method of the pipe, to change its behavior */
Expand Down