Skip to content

Commit 4620484

Browse files
authored
refactor: remove unused binaries (#110)
The minified and 32bit binaries have not been in use for a while. As such this PR removes them. BREAKING CHANGE: The minified and 32bit binaries are removed.
1 parent 6d3d153 commit 4620484

File tree

3 files changed

+1
-21
lines changed

3 files changed

+1
-21
lines changed

.github/workflows/release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ jobs:
2323
- run: go version
2424

2525
- name: 'Build cli'
26-
run: yarn build:cli:upx
26+
run: yarn build:cli
2727

2828
- uses: actions/github-script@v6
2929
with:

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
"scripts": {
66
"build:lib": "node --no-warnings=ExperimentalWarning --loader ts-node/esm/transpile-only ./scripts/build-lib.mts",
77
"build:cli": "node --no-warnings=ExperimentalWarning --loader ts-node/esm/transpile-only ./scripts/build-cli.mts",
8-
"build:cli:upx": "node --no-warnings=ExperimentalWarning --loader ts-node/esm/transpile-only ./scripts/build-cli.mts upx",
98
"build:ngssc": "ng run ngssc-app:ngsscbuild:production",
109
"build:demo": "ng build ngssc-app",
1110
"build:demo-i18n": "ng build ngssc-app -c i18n",

scripts/build-cli.mts

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -9,15 +9,12 @@ const dist = join(root, 'dist', 'cli');
99
const version = JSON.parse(readFileSync(join(root, 'package.json'), 'utf8')).version;
1010
const cliDirectory = join(root, 'cli');
1111
const binaries: { os: string; arch: string; fileName: string, alias?: string }[] = [
12-
{ os: 'windows', arch: '386', fileName: 'ngssc_32bit.exe' },
1312
{ os: 'windows', arch: 'amd64', fileName: 'ngssc_amd64.exe', alias: 'ngssc_64bit.exe' },
14-
{ os: 'linux', arch: '386', fileName: 'ngssc_32bit' },
1513
{ os: 'linux', arch: 'amd64', fileName: 'ngssc_amd64', alias: 'ngssc_64bit' },
1614
{ os: 'linux', arch: 'arm64', fileName: 'ngssc_arm64' },
1715
{ os: 'darwin', arch: 'amd64', fileName: 'ngssc_darwin_amd64', alias: 'ngssc_darwin_64bit' },
1816
{ os: 'darwin', arch: 'arm64', fileName: 'ngssc_darwin_arm64' },
1917
];
20-
const buildUpx = process.argv[2] === 'upx';
2118

2219
const asyncExec = promisify(exec);
2320
await Promise.all(
@@ -40,22 +37,6 @@ await Promise.all(
4037
await cp(binaryDist, join(dist, binary.alias));
4138
console.log(`Created alias for ${binary.os} ${binary.arch}: ${binary.alias}`);
4239
}
43-
44-
if (buildUpx) {
45-
const [fileName, extension] = binary.fileName.split('.');
46-
const minFileName = `${fileName}_min${extension ? `.${extension}` : ''}`;
47-
const minBinaryDist = join(dist, minFileName);
48-
console.log(`Building upx binary for ${binary.os} ${binary.arch}`);
49-
await cp(binaryDist, minBinaryDist);
50-
await asyncExec(`upx --brute ${minBinaryDist}`);
51-
console.log(`Finished compressing binary for ${binary.os} ${binary.arch}: ${minFileName}`);
52-
if (binary.alias) {
53-
const [fileName, extension] = binary.alias.split('.');
54-
const aliasFileName = `${fileName}_min${extension ? `.${extension}` : ''}`;
55-
await cp(minBinaryDist, join(dist, aliasFileName));
56-
console.log(`Created alias for compressed ${binary.os} ${binary.arch}: ${aliasFileName}`);
57-
}
58-
}
5940
}),
6041
);
6142

0 commit comments

Comments
 (0)