Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate interface loop detection configuration to MongoDB #61

Open
viniarck opened this issue Aug 3, 2022 · 1 comment
Open

Migrate interface loop detection configuration to MongoDB #61

viniarck opened this issue Aug 3, 2022 · 1 comment

Comments

@viniarck
Copy link
Member

viniarck commented Aug 3, 2022

As highlighted in the original EP025:

Specification
It is desirable to support ignored loops configuration that can be changed dynamically via API. Since this feature is relatively small and wouldn't require much extra entries or states, then using topology switches' and interfaces' metadata storage would simplify the implementation and maintenance since currently adding support to a new storage with storehouse requires a significant effort development-wise. In the future, this can be migrated to another storage (collection) when an alternative is available. The following metadata would be used

Back then, MongoDB infrastructure hadn't been in place yet to we made this trade-off to ship this feature, but now the configuration part (ignored_loops) that is used can be migrated to MongoDB eventually with a new API endpoint. This would imply also adapting this e2e test case too https://github.com/amlight/kytos-end-to-end-tests/blob/master/tests/test_e2e_32_of_lldp.py#L78.

I'll tag this a future_release

@viniarck viniarck added the future_release Planned for the next release label Aug 3, 2022
@viniarck
Copy link
Member Author

viniarck commented Aug 3, 2022

Before prioritizing this in the future, it's worth reassessing the approach how NApps are using the settings and maybe provide a generic solutions providing a default settings storage too simplifying this and future similar implemenations that other NApps will need.

@viniarck viniarck removed the future_release Planned for the next release label Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant