fix: unexported dynamic builders resulting in ts(2742) when composite: true. (#1578)

Author: igalklebanov

.github/workflows/test.yml

@@ -347,3 +347,31 @@ jobs:
 
       - name: Run TypeScript Native tests
         run: pnpx @typescript/native-preview --project ./test/node/tsconfig.json
+
+  typescript-composite:
+    name: TypeScript Composite
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Harden Runner
+        uses: step-security/harden-runner@f4a75cfd619ee5ce8d5b864b0d183aff3c69b55a # v2.13.1
+        with:
+          egress-policy: audit
+
+      - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
+
+      - name: Install pnpm
+        uses: pnpm/action-setup@a7487c7e89a18df4991f7f222e4898a00d66ddda # v4.1.0
+
+      - name: Use Node.js
+        uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5.0.0
+        with:
+          cache: 'pnpm'
+          node-version: lts/*
+
+      - name: Install dependencies
+        run: pnpm i
+
+      - name: Test
+        working-directory: test/composite-ts
+        run: npm i && npm run check:types

.gitignore

@@ -4,3 +4,4 @@ dist
 node_modules
 .vscode
 .idea
+tsconfig.tsbuildinfo

package.json

@@ -138,5 +138,5 @@
     "tsd": "^0.33.0",
     "typescript": "~5.9.2"
   },
-  "packageManager": "pnpm@10.16.0+sha512.8066e7b034217b700a9a4dbb3a005061d641ba130a89915213a10b3ca4919c19c037bec8066afdc559b89635fdb806b16ea673f2468fbb28aabfa13c53e3f769"
+  "packageManager": "pnpm@10.16.1+sha512.0e155aa2629db8672b49e8475da6226aa4bdea85fdcdfdc15350874946d4f3c91faaf64cbdc4a5d1ab8002f473d5c3fcedcd197989cf0390f9badd3c04678706"
 }

pnpm-workspace.yaml

@@ -10,6 +10,9 @@ ignoredBuiltDependencies:
 
 minimumReleaseAge: 1440 # install package versions that are at least 1 day old (in minutes).
 
+minimumReleaseAgeExclude:
+  - '@types/node'
+
 # `postinstall` allow list
 onlyBuiltDependencies:
   - better-sqlite3

src/index.ts

@@ -60,6 +60,8 @@ export * from './schema/drop-view-builder.js'
 export * from './schema/alter-column-builder.js'
 
 export * from './dynamic/dynamic.js'
+export * from './dynamic/dynamic-reference-builder.js'
+export * from './dynamic/dynamic-table-builder.js'
 
 export * from './driver/driver.js'
 export * from './driver/database-connection.js'

test/composite-ts/foo.mts

@@ -0,0 +1,12 @@
+import { Kysely } from 'kysely'
+
+export function foo<T extends 'myColumn'>(
+  db: Kysely<{
+    MyTable: {
+      myColumn: string
+    }
+  }>,
+  field: T,
+) {
+  return db.selectFrom('MyTable').select(field)
+}

test/composite-ts/package-lock.json

@@ -0,0 +1,13 @@
+{
+  "type": "module",
+  "scripts": {
+    "precheck:types": "cd ../.. && pnpm build && cp -r dist test/composite-ts/node_modules/kysely/",
+    "check:types": "tsc --noEmit"
+  },
+  "devDependencies": {
+    "typescript": "^5.8.3"
+  },
+  "dependencies": {
+    "kysely": "*"
+  }
+}

test/composite-ts/package.json

@@ -0,0 +1,12 @@
+{
+  "compilerOptions": {
+    "lib": ["ESNext"],
+    "module": "ES2022",
+    "moduleResolution": "Bundler",
+    "composite": true,
+    "skipLibCheck": true,
+    "strict": true
+  },
+  "exclude": ["node_modules"],
+  "include": ["foo.mts"]
+}