Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle dot in metadata key name #95

Closed
karlicoss opened this issue Apr 13, 2019 · 2 comments
Closed

Handle dot in metadata key name #95

karlicoss opened this issue Apr 13, 2019 · 2 comments
Labels
Milestone

Comments

@karlicoss
Copy link

karlicoss commented Apr 13, 2019

So I ran into a need to filter metadata key containing dot, which interferes with the way the key filter is specified in git .config file, since nbstripout uses dot as nestedness seprarator. Sadly, I don't control the key names either, they are coming from EIN Emacs plugin and seem to be hardcoded.

For now I just hacked nbstripout to treat dot as part of key name, but that's of course not a proper fix. Thought for a bit, but couldn't come up with a good backwards compatible solution for specifying keys containing dots, so at least leaving this issue here...

@kynan
Copy link
Owner

kynan commented Jun 28, 2020

Sorry for the late reply. One potential option I could see is specifying metadata keys as lists instead of dot separated strings. That's a bit of effort when also trying to maintain backwards compatibility. Given that JSON keys also cannot contain dots I think lobbying for your plugin to change their metadata seems like a better solution.

Let me know what you think and if you're still facing this issue.

@kynan kynan added this to the Backlog milestone Jun 28, 2020
@kynan kynan added the state:waiting Waiting for response for reporter label Jun 28, 2020
@kynan
Copy link
Owner

kynan commented Apr 11, 2021

This is the same as #143, which has been addressed in #144. Please reopen if that doesn't resolve your use case.

@kynan kynan modified the milestones: Backlog, 0.4.0 Apr 11, 2021
@kynan kynan closed this as completed Apr 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants