Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.3.8 version is not compatible with Python 2 but installed by pip #128

Closed
paskino opened this issue Jun 10, 2020 · 2 comments
Closed

0.3.8 version is not compatible with Python 2 but installed by pip #128

paskino opened this issue Jun 10, 2020 · 2 comments

Comments

@paskino
Copy link

paskino commented Jun 10, 2020

I installed nbstripout (thanks!) with pip on python2.7 on ubuntu 18.04.

I got the following error due to different signature of the open function with python 2 and 3.

The problem I'm reporting is with the pip package that does not realise that the latest version 0.3.8 is incompatible with python2.

default: Traceback (most recent call last):
    default:   File "/home/sirfuser/.local/bin/nbstripout", line 8, in <module>
    default:
    default: sys.exit(main())
    default:   File "/home/sirfuser/.local/lib/python2.7/site-packages/nbstripout/_nbstripout.py", line 295, in main
    default:
    default: sys.exit(install(git_config, user=args._global, attrfile=args.attributes))
    default:   File "/home/sirfuser/.local/lib/python2.7/site-packages/nbstripout/_nbstripout.py", line 173, in install
    default:
    default: with open(attrfile, 'a', newline='') as f:
    default: TypeError
    default: :
    default: 'newline' is an invalid keyword argument for this function
@paskino
Copy link
Author

paskino commented Jun 11, 2020

To be honest, given that Python2 has been dropped this isn't quite an issue. But it's worth mentioning it in your readme.

@paskino paskino closed this as completed Jun 11, 2020
@kynan
Copy link
Owner

kynan commented Jun 23, 2020

Thanks, will add a note that Python 2 is no longer supported.

kynan added a commit that referenced this issue Jun 24, 2020
@kynan kynan self-assigned this Jun 24, 2020
@kynan kynan added this to the 0.3.9 milestone Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants