Skip to content

Commit 5c60a78

Browse files
authored
Merge pull request #7 from kwonoj/bump-emscripten
fix(preamble): use upstream preamble environment detection
2 parents a99d6b6 + 1992214 commit 5c60a78

File tree

2 files changed

+3
-37
lines changed

2 files changed

+3
-37
lines changed

Dockerfile

Lines changed: 3 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM ojkwon/arch-nvm-node:7b0d30e-node8.4-npm5.4.1
1+
FROM ojkwon/arch-nvm-node:6c538cc-node7.9-npm5.4.2
22
MAINTAINER OJ Kwon <kwon.ohjoong@gmail.com>
33

44
# Build time args
@@ -13,31 +13,12 @@ RUN pacman --noconfirm -S \
1313
python \
1414
python-setuptools \
1515
python2-setuptools \
16-
jre8-openjdk
17-
# emscripten // disabled while installing pinned down version
16+
jre8-openjdk \
17+
emscripten
1818

1919
# Change subsequent execution shell to bash
2020
SHELL ["/bin/bash", "-l", "-c"]
2121

22-
#START emscripten--------------------------------
23-
# Install emscripten-1.37.18-1-x86_64.pkg.tar.xz
24-
# until binaryen clang failure (https://github.com/WebAssembly/binaryen/issues/1164) resolved
25-
26-
RUN cd $TMPDIR && \
27-
curl https://archive.archlinux.org/packages/e/emscripten/emscripten-1.37.18-1-x86_64.pkg.tar.xz > ./emscripten-1.37.18-1-x86_64.pkg.tar.xz && \
28-
curl https://archive.archlinux.org/packages/e/emscripten/emscripten-1.37.18-1-x86_64.pkg.tar.xz.sig > ./emscripten-1.37.18-1-x86_64.pkg.tar.xz.sig && \
29-
sudo pacman --noconfirm -U emscripten-1.37.18-1-x86_64.pkg.tar.xz
30-
31-
#END emscripten--------------------------------
32-
33-
#START preamble patch--------------------------------
34-
# Patch preamble.js to support Electron's renderer process with node.js environment
35-
# Refer https://github.com/kripken/emscripten/pull/5577 for detail.
36-
# TODO: remove based on upstream PR status
37-
COPY ./preamble.patch $TMPDIR/
38-
RUN patch /usr/lib/emscripten/src/preamble.js $TMPDIR/preamble.patch
39-
#END preamble patch--------------------------------
40-
4122
# Initialize emcc
4223
RUN emcc
4324

preamble.patch

Lines changed: 0 additions & 15 deletions
This file was deleted.

0 commit comments

Comments
 (0)