Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement columnar accumulator states #645

Open
richox opened this issue Nov 11, 2024 · 0 comments · May be fixed by #646
Open

implement columnar accumulator states #645

richox opened this issue Nov 11, 2024 · 0 comments · May be fixed by #646
Labels
enhancement New feature or request performance related Potential optimization point

Comments

@richox
Copy link
Collaborator

richox commented Nov 11, 2024

Is your feature request related to a problem? Please describe.
in HashAggregateExec, currently all accumutors share the same AccumRow in one grouped record, which requires a lot of bytes-hacking and the performance is not good. we should consider using seperated row for each accumulator, so that we can update each AccumColumn independently. only convert columns to rows when doing partial merging.

Describe the solution you'd like

  1. implement a common trait AccumColumn, replacing the old AccumRow.
  2. implement columnar updating/merging.
  3. implement C2R for partial merging.

Describe alternatives you've considered
further more, we can use columnar storage for partial merging, this requires more complex handling of output schema of partial aggr.
Additional context

@richox richox added enhancement New feature or request performance related Potential optimization point labels Nov 11, 2024
@richox richox linked a pull request Nov 11, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request performance related Potential optimization point
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant