From 76dc3a28c05a1d9fd52b3242a81cf3e5ae107e09 Mon Sep 17 00:00:00 2001 From: Patrick Ellis <319655+pje@users.noreply.github.com> Date: Tue, 14 May 2024 13:50:33 -0400 Subject: [PATCH] =?UTF-8?q?Upgrade=20node20:=2020.8.1=20=E2=86=92=2020.13.?= =?UTF-8?q?1=20(#3284)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * Upgrade node20: 20.8.1 → 20.13.1 * Call out the release process for `alpine_nodejs` in a comment * move the comment to the end of the line so it's more obvious which variable it's talking about --- src/Misc/externals.sh | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/Misc/externals.sh b/src/Misc/externals.sh index 383221e4452..e057ecb218f 100755 --- a/src/Misc/externals.sh +++ b/src/Misc/externals.sh @@ -5,10 +5,11 @@ PRECACHE=$2 NODE_URL=https://nodejs.org/dist UNOFFICIAL_NODE_URL=https://unofficial-builds.nodejs.org/download/release NODE_ALPINE_URL=https://github.com/actions/alpine_nodejs/releases/download +# When you update Node versions you must also create a new release of alpine_nodejs at that updated version. +# Follow the instructions here: https://github.com/actions/alpine_nodejs?tab=readme-ov-file#getting-started NODE16_VERSION="16.20.2" -NODE20_VERSION="20.8.1" -# used only for win-arm64, remove node16 unofficial version when official version is available -NODE16_UNOFFICIAL_VERSION="16.20.0" +NODE20_VERSION="20.13.1" +NODE16_UNOFFICIAL_VERSION="16.20.0" # used only for win-arm64, remove node16 unofficial version when official version is available get_abs_path() { # exploits the fact that pwd will print abs path when no args