Merge pull request #342 from kuzzleio/5.0.14-proposal

Release 5.0.14

Author: benoitvidis

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "kuzzle-sdk",
-  "version": "5.0.13",
+  "version": "5.0.14",
   "description": "Official Javascript SDK for Kuzzle",
   "author": "The Kuzzle Team <support@kuzzle.io>",
   "repository": {

package.json

@@ -5,8 +5,8 @@ var
   getKeys = {getter: true, required: ['keys']},
   getMember = {getter: true, required: ['_id', 'member']},
   getxScan = {
-    getter: true, 
-    required: ['_id', 'cursor'], 
+    getter: true,
+    required: ['_id', 'cursor'],
     opts: ['match', 'count'],
     mapResults: mapScanResults
   },
@@ -129,7 +129,7 @@ var
     sismember: getMember,
     smembers: getId,
     smove: {required: ['_id', 'destination', 'member']},
-    sort: {getter: true, required: ['_id'], opts: ['alpha', 'by', 'direction', 'get', 'limit']},
+    sort: {required: ['_id'], opts: ['alpha', 'by', 'direction', 'get', 'limit']},
     spop: {required: ['_id'], opts: ['count'], mapResults: mapStringToArray },
     srandmember: {getter: true, required: ['_id'], opts: ['count'], mapResults: mapStringToArray},
     srem: {required: ['_id', 'members']},
@@ -500,7 +500,7 @@ function mapZrangeResults(results) {
  *   "<cursor>",
  *   [
  *     "value1",
- *     "value2", 
+ *     "value2",
  *     "..."
  *   ]
  * ]
@@ -514,8 +514,8 @@ function mapZrangeResults(results) {
  *     "..."
  *   ]
  * }
- * 
- * @param  {array.<string|array>} results 
+ *
+ * @param  {array.<string|array>} results
  * @return {object}
  */
 function mapScanResults(results) {

src/MemoryStorage.js

@@ -311,18 +311,20 @@ Room.prototype.setHeaders = function (content, replace) {
  * @returns {*}
  */
 function notificationCallback (data) {
+  var notificationData = Object.assign({}, data);
+
   if (data.type === 'TokenExpired') {
     this.kuzzle.jwtToken = undefined;
     return this.kuzzle.emitEvent('tokenExpired');
   }
 
-  if (data.type === 'document') {
-    data.document = new Document(this.collection, data.result._id, data.result._source, data.result._meta);
-    delete data.result;
+  if (notificationData.type === 'document') {
+    notificationData.document = new Document(this.collection, notificationData.result._id, notificationData.result._source, notificationData.result._meta);
+    delete notificationData.result;
   }
 
-  if (this.subscribeToSelf || !data.volatile || data.volatile.sdkInstanceId !== this.kuzzle.id) {
-    this.callback(null, data);
+  if (this.subscribeToSelf || !notificationData.volatile || notificationData.volatile.sdkInstanceId !== this.kuzzle.id) {
+    this.callback(null, notificationData);
   }
 }
 

src/Room.js

@@ -1103,7 +1103,7 @@ describe('MemoryStorage methods', function () {
   });
 
   it('#sort', function () {
-    return testReadCommand(
+    return testWriteCommand(
       'sort',
       ['key'],
       {alpha: true, by: 'foo', direction: 'asc', get: ['foo', 'bar'], limit: {count: 0, offset: 1}},

test/MemoryStorage/methods.test.js

@@ -374,6 +374,33 @@ describe('Room methods', function () {
         .be.an.instanceOf(Document);
     });
 
+    it('should not alter the notification data', function () {
+      var
+        data = {
+          controller: 'document',
+          type: 'document',
+          result: {
+            _id: 'id',
+            _source: {
+              foo: 'bar'
+            }
+          }
+        };
+
+      notifCB.call(room, data);
+
+      should(data).match({
+        controller: 'document',
+        type: 'document',
+        result: {
+          _id: 'id',
+          _source: {
+            foo: 'bar'
+          }
+        }
+      });
+    });
+
     it('should handle realtime publish notifications', function () {
       notifCB.call(room, {
         controller: 'realtime',