Merge pull request #196 from kuzzleio/msbugfix

Fix ms.hgetall return value interpretation

Author: jenow

src/MemoryStorage.js

@@ -65,7 +65,7 @@ var
     hdel: {required: ['_id', 'fields']},
     hexists: getIdField,
     hget: getIdField,
-    hgetall: {getter: true, required: ['_id'], mapResults: mapKeyValueResults},
+    hgetall: {getter: true, required: ['_id']},
     hincrby: setIdFieldValue,
     hincrbyfloat: {required: ['_id', 'field', 'value'], mapResults: parseFloat},
     hkeys: getId,
@@ -453,31 +453,6 @@ function mapArrayStringToArrayInt(results) {
   });
 }
 
-/**
- * Map results like ['key', 'value', 'key', 'value', ...]
- * to a JSON object {key: 'value', ...}
- *
- * @param {Array.<string>} results
- * @return {Object}
- */
-function mapKeyValueResults(results) {
-  var
-    buffer = null,
-    mapped = {};
-
-  results.forEach(function (value) {
-    if (buffer === null) {
-      buffer = value;
-    }
-    else {
-      mapped[buffer] = value;
-      buffer = null;
-    }
-  });
-
-  return mapped;
-}
-
 /**
  * Map zrange results with WITHSCORES:
  * [

test/MemoryStorage/methods.test.js

@@ -407,7 +407,7 @@ describe('MemoryStorage methods', function () {
       {},
       {_id: 'key'},
       {},
-      ['foo', 'bar', 'baz', 'qux'],
+      {foo: 'bar', baz: 'qux'},
       {foo: 'bar', baz: 'qux'}
     );
   });