Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable padding for titlebar (especially relevant for Gnome-theme) #22

Closed
ripefig opened this issue Dec 27, 2018 · 6 comments
Closed
Labels
enhancement New feature or request fixed

Comments

@ripefig
Copy link

ripefig commented Dec 27, 2018

to get a bigger titlebar right now, you need to scale up the button glyphs. Huge glyphs look pretty bad. I think it would be nice to be able to increase the size of the titlebar and buttons without increasing the size of the glyphs:

2

@kupiqu kupiqu added this to the V1.0 milestone Dec 27, 2018
@kupiqu
Copy link
Owner

kupiqu commented Dec 27, 2018

Personally I find "tiny symbols in big rectangles" a waste of (vertical) space, but that's just my opinion.

I guess one way to address this would be when implementing #21 making the size of the button rather small in comparison to the size of the rectangle.

I can guide anyone wanting to give this a try...

EDIT: I don't think adding an extra parameter for this is needed or useful, instead I'd prefer this to be just the behavior for the gnome button style only

@kupiqu
Copy link
Owner

kupiqu commented Nov 19, 2019

Closing for lack of interest. I'm open to review a pull request

@kupiqu kupiqu closed this as completed Nov 19, 2019
@kupiqu kupiqu removed this from the V1.0 milestone Nov 19, 2019
@kupiqu kupiqu reopened this Nov 29, 2019
@kupiqu
Copy link
Owner

kupiqu commented Nov 29, 2019

I'm reconsidering this

@kupiqu
Copy link
Owner

kupiqu commented Nov 29, 2019

relevant commit 975d5df

@kupiqu
Copy link
Owner

kupiqu commented Nov 30, 2019

I implemented the padding, will push it soon

@kupiqu
Copy link
Owner

kupiqu commented Dec 1, 2019

fixed 2ad2bdd

@kupiqu kupiqu closed this as completed Dec 1, 2019
@kupiqu kupiqu added the fixed label Dec 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed
Projects
None yet
Development

No branches or pull requests

2 participants