Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rounded border on maximized window #104

Closed
gabelluardo opened this issue Feb 21, 2022 · 14 comments
Closed

Rounded border on maximized window #104

gabelluardo opened this issue Feb 21, 2022 · 14 comments

Comments

@gabelluardo
Copy link
Contributor

On maximized window, rounded title bar border show the background

This is an example with 20px border radius:

immagine

with the default breeza this doesn't happen:

immagine

I think it sets the radius to 0px on maximized windows

@kupiqu
Copy link
Owner

kupiqu commented Jun 23, 2022

This is (perhaps was) a KDE bug, most likely fixed with #107, closing now.

@kupiqu kupiqu closed this as completed Jun 23, 2022
@gabelluardo
Copy link
Contributor Author

gabelluardo commented Nov 5, 2022

This seems to have reappeared with Plasma 5.26

@kupiqu
Copy link
Owner

kupiqu commented Nov 6, 2022

Not sure what you mean exactly. Do you mean when the titlebar is not present on maximization?

If so, please note that SBE here is intended to work different than Breeze as it keeps the borders. Just removing the titlebar including borders looks ugly (personal opinion), and round corners are consistent to this, SBE only removes the titlebar, but keeps all the rest: borders, outline, corners and shadows

@gabelluardo
Copy link
Contributor Author

I mean the title bar is rounded even on maximization
immagine
immagine

@kupiqu
Copy link
Owner

kupiqu commented Nov 6, 2022

If I understand you correctly, this is the intended behavior

@Syndrizzle
Copy link

If I understand you correctly, this is the intended behavior

would it be possible to make this optional?

@kupiqu
Copy link
Owner

kupiqu commented Dec 1, 2022

I may consider revising a pull request...

but I am still confused about what you are exactly asking for. What is the behavior of maximized windows that you would prefer in terms of [titlebar (on/off), rounded corners (on/off), outline (on/off) and shadows (on/off)]?

@Syndrizzle
Copy link

I want that sierrabreezeenhanced disables rounded corners for maximized window

@kupiqu
Copy link
Owner

kupiqu commented Dec 1, 2022

I may revise a PR if you convince me of why should regular users bother about rounded corners appearing in maximized windows in contrast to others.

@Syndrizzle
Copy link

It looks weird on no gaps, imagine seeing some space in the corner of your screen when your app is Maximized, even windows 11 doesn't keep them round...

@kupiqu
Copy link
Owner

kupiqu commented Dec 2, 2022

Fair enough. I use (1px) gaps and small (3 px) rounded corners, with no titlebar on maximized windows and it looks good.
If you (or sb else) wants to work on this and submit a PR, I will revise it.

@Syndrizzle
Copy link

Only if I knew how to write C++ :(

@gabelluardo
Copy link
Contributor Author

If you give me any suggestions on where to start, I can work on it

@Syndrizzle
Copy link

I am sorry, but I don't know about anything coming to my mind. I tried my best and I guess you can take a look at https://github.com/a-parhom/LightlyShaders/blob/c8e6b15abbb9918313fd1f76d040dd7e9380eed2/lightlyshaders.cpp#L222. That KDE rounded corners tool, it has 2 branches, the code is from main branch. Unfortunately, the main branch only works on plasma 5.25 and smaller, but refuses to compile on 5.26… the second branch works on 5.26, but relies on decorations like SierraBreezeEnhanced to provide the corners for it…. But since the main branch includes the toggle to disable for maximized window, it is possible to take a look at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants