-changed select-query to char array, confirmed to work with nginx 1.0.3 as well

Author: vishy1618

ngx_http_auth_sqlite_basic_module.c

@@ -163,14 +163,29 @@ ngx_http_auth_sqlite_basic_handler(ngx_http_request_t *r)
     // End  //
 
 
-    ngx_str_t select_query = ngx_string("");
-    select_query.len = alcf->sqlite_table.len + alcf->sqlite_user.len + login.len + alcf->sqlite_passwd.len + r->headers_in.passwd.len + strlen("select * from %s where %s = \"%s\" and %s = \"%s\"");
-    select_query.data = ngx_pnalloc(r->pool, select_query.len + 1);
-
-    ngx_snprintf(select_query.data, select_query.len, "select * from %s where %s = \"%s\" and %s = \"%s\"", alcf->sqlite_table.data, alcf->sqlite_user.data, login.data, alcf->sqlite_passwd.data, r->headers_in.passwd.data);
+    //calculating the length of the required char array
+	int ARR_LEN = strlen("select * from ") + 
+				  strlen((char *) alcf->sqlite_table.data) +
+				  strlen(" where ") +
+				  strlen((char *) alcf->sqlite_user.data) +
+				  strlen(" = \"") +
+				  strlen((char *) login.data) +
+				  strlen("\" and ") +
+				  strlen((char *) alcf->sqlite_passwd.data) +
+				  strlen(" = \"") +
+				  strlen((char *) r->headers_in.passwd.data) +
+				  strlen("\"");
+	
+	//creating array based on calculated length
+	char select_query[ARR_LEN + 1];
+	sprintf(select_query, "select * from %s where %s = \"%s\" and %s = \"%s\"", (char *) alcf->sqlite_table.data
+																			  , (char *) alcf->sqlite_user.data
+																			  , (char *) login.data
+																			  , (char *) alcf->sqlite_passwd.data
+																			  , (char *) r->headers_in.passwd.data);
 
     const char* tail;
-    sqlite_return_value = sqlite3_prepare_v2(sqlite_handle, (char *)select_query.data, strlen((char *)select_query.data), &sqlite_stmt, &tail);
+    sqlite_return_value = sqlite3_prepare_v2(sqlite_handle, select_query, strlen(select_query), &sqlite_stmt, &tail);
 
     if (sqlite_return_value != SQLITE_OK) {
       ngx_log_error(NGX_LOG_CRIT, r->connection->log, 0,  "Unable to fetch data from \"%s\" database", alcf->sqlite_db_file.data);