Skip display name ServiceInsight

[jakubdyszkiewicz]

Description

We should not show display name label in ServiceInsight

[github-actions]

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

[Icarus9913]

It's the API server response, not kubectl.

The label "kuma.io/display-name": "all-services-default" comes from the ServiceInsight resource, however in this API it shouldn't exist because the weird value all-services-default.
So, let's just remove this label.

$ curl http://localhost:5681/meshes/default/service-insights/demo-app_kuma-demo_svc_5000
{
 "type": "ServiceInsight",
 "mesh": "default",
 "name": "demo-app_kuma-demo_svc_5000",
 "creationTime": "2024-09-18T07:54:45Z",
 "modificationTime": "2024-09-18T07:54:45Z",
 "labels": {
  "kuma.io/display-name": "all-services-default"
 },
 "status": "online",
 "dataplanes": {
  "total": 1,
  "online": 1
 },
 "addressPort": "demo-app_kuma-demo_svc_5000.mesh:80"
}

[Icarus9913]

By the way, this only happens in k8s mode.

For universal mode it doesn't own that label in Meta

root@aac9440b67fb:~# curl http://localhost:5681/service-insights
{
 "total": 1,
 "items": [
  {
   "type": "ServiceInsight",
   "mesh": "default",
   "name": "backend",
   "creationTime": "2024-09-22T09:16:01.584481576Z",
   "modificationTime": "2024-09-22T09:16:02.586096122Z",
   "status": "online",
   "dataplanes": {
    "total": 1,
    "online": 1
   },
   "addressPort": "backend.mesh:80",
   "zones": [
    "wk-zone"
   ]
  }
 ],
 "next": null
}
---
root@aac9440b67fb:~# curl http://localhost:5681/meshes/default/service-insights/backend                    
{
 "type": "ServiceInsight",
 "mesh": "default",
 "name": "backend",
 "creationTime": "2024-09-22T09:16:01.584481576Z",
 "modificationTime": "2024-09-22T09:16:02.586096122Z",
 "status": "online",
 "dataplanes": {
  "total": 1,
  "online": 1
 },
 "addressPort": "backend.mesh:80",
 "zones": [
  "wk-zone"
 ]
}