Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent way of getting name of a resource #10435

Closed
slonka opened this issue Jun 11, 2024 · 4 comments
Closed

Consistent way of getting name of a resource #10435

slonka opened this issue Jun 11, 2024 · 4 comments
Labels
kind/improvement Improvement on an existing feature triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@slonka
Copy link
Contributor

slonka commented Jun 11, 2024

Description

from @lukidzi:

There are multiple ways of getting a name:

  • meta.GetName() # name from the resource
  • meta.GetNameExtensions()[model.K8sNameComponent] # "k8s.kuma.io/name"
  • GetDisplayName(meta) # "kuma.io/display-name"
  • es.Spec.GetService() # "kuma.io/service"

We should have a single way of getting the correct name so we don't mess up. E.g. when we generate resources in different places (e.g. listener in one place and cluster in another name) and we need to match them up.

@slonka slonka added triage/pending This issue will be looked at on the next triage meeting kind/feature New feature labels Jun 11, 2024
@lahabana lahabana added kind/improvement Improvement on an existing feature and removed kind/feature New feature labels Jun 12, 2024
@lobkovilya
Copy link
Contributor

Triage: we should remove meta.GetNameExtensions()[model.K8sNameComponent] and use labels instead. es.Spec.GetService() shouldn't be the case anymore as we introduced MeshExternalService, no? Let's also add docs to these methods.

@lobkovilya lobkovilya added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Jun 17, 2024
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Sep 16, 2024
Copy link
Contributor

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@slonka
Copy link
Contributor Author

slonka commented Sep 16, 2024

@lobkovilya was this solved by #10886 ?

@slonka slonka removed the triage/stale Inactive for some time. It will be triaged again label Sep 16, 2024
@lobkovilya
Copy link
Contributor

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/improvement Improvement on an existing feature triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Development

No branches or pull requests

3 participants