fix: correct error handling in processAsync

kulshekhar · Jan 19, 2024 · e7be4bf · e7be4bf
1 parent e31d953
commit e7be4bf
Showing 1 changed file with 21 additions and 23 deletions.
diff --git a/src/legacy/ts-jest-transformer.ts b/src/legacy/ts-jest-transformer.ts
@@ -189,31 +189,29 @@ export class TsJestTransformer implements SyncTransformer {
   ): Promise<TransformedSource> {
     this._logger.debug({ fileName: sourcePath, transformOptions }, 'processing', sourcePath)
 
-    return new Promise(async (resolve, reject) => {
-      const configs = this._configsFor(transformOptions)
-      const shouldStringifyContent = configs.shouldStringifyContent(sourcePath)
-      const babelJest = shouldStringifyContent ? undefined : configs.babelJestTransformer
-      let result: TransformedSource
-      const processWithTsResult = this.processWithTs(sourceText, sourcePath, transformOptions)
-      result = {
-        code: processWithTsResult.code,
-      }
-      if (processWithTsResult.diagnostics?.length) {
-        reject(configs.createTsError(processWithTsResult.diagnostics))
-      }
-      if (babelJest) {
-        this._logger.debug({ fileName: sourcePath }, 'calling babel-jest processor')
+    const configs = this._configsFor(transformOptions)
+    const shouldStringifyContent = configs.shouldStringifyContent(sourcePath)
+    const babelJest = shouldStringifyContent ? undefined : configs.babelJestTransformer
+    let result: TransformedSource
+    const processWithTsResult = this.processWithTs(sourceText, sourcePath, transformOptions)
+    result = {
+      code: processWithTsResult.code,
+    }
+    if (processWithTsResult.diagnostics?.length) {
+      throw configs.createTsError(processWithTsResult.diagnostics)
+    }
+    if (babelJest) {
+      this._logger.debug({ fileName: sourcePath }, 'calling babel-jest processor')
 
-        // do not instrument here, jest will do it anyway afterwards
-        result = await babelJest.processAsync(result.code, sourcePath, {
-          ...transformOptions,
-          instrument: false,
-        })
-      }
-      result = this.runTsJestHook(sourcePath, sourceText, transformOptions, result)
+      // do not instrument here, jest will do it anyway afterwards
+      result = await babelJest.processAsync(result.code, sourcePath, {
+        ...transformOptions,
+        instrument: false,
+      })
+    }
+    result = this.runTsJestHook(sourcePath, sourceText, transformOptions, result)
 
-      resolve(result)
-    })
+    return result
   }
 
   private processWithTs(