Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing rel attributes in author-profile.html #19

Closed
kulbhushanchand opened this issue Nov 19, 2018 · 1 comment
Closed

missing rel attributes in author-profile.html #19

kulbhushanchand opened this issue Nov 19, 2018 · 1 comment
Labels
bug Something isn't working

Comments

@kulbhushanchand
Copy link
Owner

required itemprop="sameAs" rel="nofollow noopener noreferrer" attribute at https://github.com/Kulbhushan-Chand/Kulbhushan-Chand.github.io/blob/adc5d08939acb6e0883c327ad311078994ec8288/_includes/author-profile.html#L56

however doing this we are also assigning itemprop="sameAs" to author.uri and author.email, instead of itemprop="url" and itemprop="email" respectively.

Do follow the comment reply on - mmistakes/minimal-mistakes#1948 (comment)
@kulbhushanchand kulbhushanchand added the bug Something isn't working label Nov 19, 2018
@kulbhushanchand kulbhushanchand self-assigned this Nov 20, 2018
@kulbhushanchand
Copy link
Owner Author

Fixed in 3bcc171

@kulbhushanchand kulbhushanchand removed their assignment Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kulbhushanchand