New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bcrypt considerations #6

Closed

sixcolors opened this issue Jan 20, 2023 · 1 comment · Fixed by #15

sixcolors commented Jan 20, 2023 •

edited

Loading

TODO_App/database/loginDatabase.go

Line 58 in a2282fb

    
           hashedPass, err := bcrypt.GenerateFromPassword([]byte(userInfo.Password), bcrypt.DefaultCost)

Consider limitations when using bcrypt. https://pkg.go.dev/golang.org/x/crypto/bcrypt#GenerateFromPassword

golang/go#36546 (comment)

Author

sixcolors commented Jan 22, 2023

Fun example:

M̡̢̛̖̗̘̙̜̝̞̟̠̀́̂̃̄̅̆̇̉̊̋̌̍̎̏̐̑̒̓̔̕̚ is one character, but 74 bytes (with the null terminator included)

kuki1029 mentioned this issue

Removed bcrypt due to byte size limitations. Replaced with argon2id #15

Merged

kuki1029 closed this as completed in #15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment