Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generated Go files are executable #34

Open
cloudlena opened this issue Apr 2, 2019 · 1 comment · May be fixed by #48
Open

Generated Go files are executable #34

cloudlena opened this issue Apr 2, 2019 · 1 comment · May be fixed by #48

Comments

@cloudlena
Copy link

The generated Go files all have the permissions -rwxr-xr-x. They don't need to be executable, so we should remove the xs so that it is -rw-r--r--.
@omar-polo
Copy link

It was the first thing I noticed. The culprit seems fs/fs.go:59: os.ModePerm is 0777.

@omar-polo omar-polo linked a pull request Nov 26, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix permissions of generated files omar-polo/kit
2 participants
@cloudlena @omar-polo