Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use "FUNCHOOK_CPU MATCHES <string>" #32

Merged
merged 1 commit into from
Oct 13, 2021
Merged

Use "FUNCHOOK_CPU MATCHES <string>" #32

merged 1 commit into from
Oct 13, 2021

Conversation

rumblehhh
Copy link
Contributor

FUNCHOOK_CPU STREQUAL AMD64 will fail to resolve correctly if there is a variable named AMD64.

@rumblehhh
Use "FUNCHOOK_CPU MATCHES <string>"
e21981e 
FUNCHOOK_CPU STREQUAL AMD64 will fail to resolve correctly if there is a variable named AMD64.
@rumblehhh
Copy link
Contributor Author

I had raised these previously in #18 but couldn't reproduce the issue.
We're seeing this issue crop up as one of our 3rd party deps is setting a variable called AMD64 meaning STREQUAL is resolving the AMD64's variable which is not "AMD64". This was resulting in funchook attempting to use funchook_AMD64.c as one of its sources which is incorrect as per the intended logic

@kubo kubo merged commit d2ea602 into kubo:master Oct 13, 2021
@rumblehhh rumblehhh deleted the patch-2 branch October 13, 2021 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rumblehhh @kubo