Use ExternalProject_add to download captone only #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempting to use funchook in an Android gradle build results in ninja: error: 'lib/libcapstone.a', needed by 'xyz.so', missing and no known rule to make it. Switch out the clunky use of ExternalProject_add for downloading and building capstone in favour of using it only for downloading followed by add_subdirectory.
|
Note I'd also be happy to make these changes for zydis if you'd like. |
kubo
reviewed
Oct 3, 2021
|
@rumblehhh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to use funchook in an Android gradle build results in ninja:
error: 'lib/libcapstone.a', needed by 'xyz.so', missing and no known
rule to make it. Switch out the clunky use of ExternalProject_add for
downloading and building capstone in favour of using it only for
downloading followed by add_subdirectory.