Feat: allow delete the provisioning resources #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
Codecov ReportBase: 79.31% // Head: 77.20% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #354 +/- ##
==========================================
- Coverage 79.31% 77.20% -2.11%
==========================================
Files 23 24 +1
Lines 1750 2018 +268
==========================================
+ Hits 1388 1558 +170
- Misses 278 368 +90
- Partials 84 92 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
wonderflow
reviewed
Feb 7, 2023
chivalryq
changed the title
chivalryq
force-pushed
the
feat/delete-halfway
branch
from
3ce0a16
to
85059f8
Compare
Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com> Fix test script Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com> better error reporting in CI Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com> report stderr Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com> relative path Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com> fix git cred test Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com> wait job done Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com> debug Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com> debug Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com> debug Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com> debug Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com> smaller resource request Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
chivalryq
force-pushed
the
feat/delete-halfway
branch
from
68db52c
to
24190d6
Compare
Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
wonderflow
reviewed
Feb 9, 2023
chart/values.yaml
Outdated
| cpu: "1000m" | ||
| memory: "2Gi" | ||
| cpu: "500m" | ||
| memory: "1Gi" |
There was a problem hiding this comment.
you can keep the limits quota, just reduce the requests.
wonderflow
reviewed
Feb 9, 2023
chart/values.yaml
Outdated
| cpu: "1000m" | ||
| memory: "2Gi" | ||
| cpu: "500m" | ||
| memory: "1Gi" |
There was a problem hiding this comment.
can we make it even smaller?
There was a problem hiding this comment.
Yes, this is for pod where run terraform apply which doesn't require much resources
Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
This was referenced Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Qiaozp qiaozhongpei.qzp@alibaba-inc.com
Add a feature gate:
AllowDeleteProvisioningResource. When enabled, controller will allow to delete Configuration in the state ofProvisioningAndChecking. This is useful when developing new configuration.Here's some examples.
Before, we have no method to delete this Configuration other than delete the
finalizerfields manually and delete the created resources on vendor's console, which is tedious and annoying.Now created resource can be deleted by controller automatically.