Add .editorconfig to .gitignore #9484
Conversation
k8s-ci-robot
added
the
size/XS
k8s-ci-robot
added
the
cncf-cla: yes
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit c1b94d4 https://deploy-preview-9484--kubernetes-io-master-staging.netlify.com |
| @@ -29,3 +29,6 @@ nohup.out | |||
|
|
|||
| # Hugo output | |||
| public/ | |||
|
|
|||
| # User-specific editorconfig files | |||
| .editorconfig | |||
There was a problem hiding this comment.
What kind of stuff would go in here? You can set your editor in your ~/.gitconfig or /git/config, which don't need to go in the repo's base directory and thus don't need to be ignored.
There was a problem hiding this comment.
Check the URL in the description for more info. Editor configs are a standardized format for configuring a wide variety of editors (VS Code, Sublime, etc).
|
/lgtm Maybe you can bring up the editorconfig in a sig-docs meeting and propose the type of config we would like to try to enforce as a SIG, for people who want to use this. Maybe 80 columns and 2 spaces for a tabstop is a good place to start? I don't think we want to get too picky, and no matter what we do, we don't want to do anything that will reformat entire files when someone only wanted to edit a small thing. |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mistyhacks The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@mistyhacks Good idea, and I'll do a bit of research to see if there are any lurking downsides. |
I find
.editorconfigfiles to be an indispensable part of my doc-writing workflow. I'd like to be able to apply my own when working on the k8s website without imposing an editor config on others. This PR makes Git ignore any user-specific.editorconfigfiles.