Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.10 PR template #7131

Merged
merged 2 commits into from
Feb 14, 2018
Merged

1.10 PR template #7131

merged 2 commits into from
Feb 14, 2018

Conversation

Bradamant3
Copy link
Contributor

@Bradamant3 Bradamant3 commented Jan 29, 2018

Add reminder about 1.10 release branch to PR template

/assign @zacharysarah


This change is Reviewable

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 29, 2018
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2018
@Bradamant3 Bradamant3 requested review from zacharysarah and removed request for tengqm and zhangxiaoyu-zidif January 29, 2018 20:21
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 3ddb603

https://deploy-preview-7131--kubernetes-io-master-staging.netlify.com

@zacharysarah
Copy link
Contributor

@Bradamant3 Sorry I let this sit so long!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 14, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bradamant3, zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these OWNERS Files:
  • OWNERS [Bradamant3,zacharysarah]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 73986a0 into kubernetes:master Feb 14, 2018
tehut pushed a commit to tehut/website that referenced this pull request Feb 20, 2018
* add 1.10 release info to PR template

* fix typo
bsalamat pushed a commit to bsalamat/kubernetes.github.io that referenced this pull request Feb 23, 2018
* add 1.10 release info to PR template

* fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants