-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a blog for volume group snapshots beta #48420
Conversation
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
/sig storage |
Hey hey, When will this piece be ready for review? Let us know if you need something from us, otherwise we will just mark it as ready for review and have sig-docs-blogs review it for content and the assigned SIG to chime in for a tech review. Thank you! |
@mbianchidev Thanks for the reminder! I'll get the blog ready to review by 11/25. |
1ec7dd6
to
1c60865
Compare
1c60865
to
9cbe8ee
Compare
Amazing work @xing-yang can you please edit the metadata as follows?
Basically adding Thank you for your collaboration and again, amazing work :) |
9cbe8ee
to
bf6539e
Compare
Thanks @mbianchidev! Addressed your comment. |
bf6539e
to
af9d009
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor changes, the rest LGTM
content/en/blog/_posts/2024-12-11-volume-group-snapshot-beta.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2024-12-11-volume-group-snapshot-beta.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2024-12-11-volume-group-snapshot-beta.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My thoughts.
I hope this helps get a polished article ahead of the deadline @xing-yang
content/en/blog/_posts/2024-12-11-volume-group-snapshot-beta.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2024-12-11-volume-group-snapshot-beta.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2024-12-11-volume-group-snapshot-beta.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2024-12-11-volume-group-snapshot-beta.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2024-12-11-volume-group-snapshot-beta.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2024-12-11-volume-group-snapshot-beta.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2024-12-11-volume-group-snapshot-beta.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2024-12-11-volume-group-snapshot-beta.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2024-12-11-volume-group-snapshot-beta.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2024-12-11-volume-group-snapshot-beta.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xing-yang I recommend you only mark things resolved once you have pushed a change that resolves them.
I have un-resolved a set of things where I don't see any fix yet.
af9d009
to
19e2c2a
Compare
@sftim I addressed your comments. Please take a look. Thanks. |
/lgtm |
LGTM label has been added. Git tree hash: 109e8231d51c9f450470e01a1fa8cf561c1efcd9
|
Thanks @xing-yang |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sftim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
This is a blog PR for moving volume group snapshots to beta.
Issue
Closes: #