Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a blog for volume group snapshots beta #48420

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

xing-yang
Copy link
Contributor

@xing-yang xing-yang commented Oct 18, 2024

Description

This is a blog PR for moving volume group snapshots to beta.

Issue

Closes: #

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/blog Issues or PRs related to the Kubernetes Blog subproject labels Oct 18, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 18, 2024
@k8s-ci-robot k8s-ci-robot requested a review from sftim October 18, 2024 15:59
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 18, 2024
Copy link

netlify bot commented Oct 18, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 19e2c2a
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/674e00d00d0a3c0008305a4e
😎 Deploy Preview https://deploy-preview-48420--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sftim
Copy link
Contributor

sftim commented Oct 19, 2024

/sig storage

@k8s-ci-robot k8s-ci-robot added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Oct 19, 2024
@mbianchidev
Copy link
Member

Hey hey,
it's Matteo here, Comms Lead for 1.32

When will this piece be ready for review?
Reminder that the review deadline is on the 25th of November.

Let us know if you need something from us, otherwise we will just mark it as ready for review and have sig-docs-blogs review it for content and the assigned SIG to chime in for a tech review.

Thank you!

@xing-yang
Copy link
Contributor Author

@mbianchidev Thanks for the reminder! I'll get the blog ready to review by 11/25.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 24, 2024
@xing-yang xing-yang changed the title [WIP] Add a placeholder PR for a blog for volume group snapshots beta Add a blog for volume group snapshots beta Nov 24, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 24, 2024
@mbianchidev
Copy link
Member

Amazing work @xing-yang can you please edit the metadata as follows?

---
layout: blog
title: "Kubernetes 1.32: Moving Volume Group Snapshots to Beta"
date: 2024-12-11
slug: kubernetes-1-32-volume-group-snapshot-beta
draft: true
author: >
   Xing Yang (VMware by Broadcom)
---

Basically adding draft: true so that we can merge the blog without worrying about the publication date and handle that ourselves (as Comms) in a separated PR that won't change any of the content you've written.
In this way we smoothen the publication process and avoid back and forth due to eventual date shufflings.

Thank you for your collaboration and again, amazing work :)

@xing-yang
Copy link
Contributor Author

Thanks @mbianchidev! Addressed your comment.

Copy link
Member

@mbianchidev mbianchidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor changes, the rest LGTM

Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My thoughts.

I hope this helps get a polished article ahead of the deadline @xing-yang

Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xing-yang I recommend you only mark things resolved once you have pushed a change that resolves them.

I have un-resolved a set of things where I don't see any fix yet.

@xing-yang
Copy link
Contributor Author

@sftim I addressed your comments. Please take a look. Thanks.

@mbianchidev
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 3, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 109e8231d51c9f450470e01a1fa8cf561c1efcd9

@sftim
Copy link
Contributor

sftim commented Dec 3, 2024

Thanks @xing-yang
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2024
@k8s-ci-robot k8s-ci-robot merged commit 5cef7f7 into kubernetes:main Dec 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Status: Published
Development

Successfully merging this pull request may close these issues.

4 participants