Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add document link for volume group snapshots #48419

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

xing-yang
Copy link
Contributor

Description

This PR adds a doc link for the Volume Group Snapshot feature.

Issue

Closes: #

@k8s-ci-robot k8s-ci-robot added this to the 1.32 milestone Oct 18, 2024
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language labels Oct 18, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 18, 2024
Copy link

netlify bot commented Oct 18, 2024

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 5e5f909
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/6712845f9619280008e1b206

Copy link

netlify bot commented Oct 18, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 5e5f909
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6712845f9619280008e1b20b
😎 Deploy Preview https://deploy-preview-48419--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@spurin
Copy link
Contributor

spurin commented Nov 11, 2024

Hi @jingxu97 @yuxiangqian, James Spurin 👋, 1.32 Docs Shadow here, are you able to review this please?

@xing-yang xing-yang changed the title [WIP] Add document link for volume group snapshots Add document link for volume group snapshots Nov 18, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 18, 2024
@jingxu97
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 18, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0951d371ca7c8ba1951e4662c1ee4904e37a575e

@nate-double-u
Copy link
Contributor

Thanks for this @xing-yang

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jingxu97, nate-double-u

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2024
@k8s-ci-robot k8s-ci-robot merged commit ca04bf2 into kubernetes:dev-1.32 Nov 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants