tutorials/guestbook, tutorials/cassandra: import latest #4775
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
Deploy preview ready! Built with commit 9bc623c https://deploy-preview-4775--kubernetes-io-master-staging.netlify.com |
|
ping @cody-clark |
ahmetb
changed the title
|
I just updated this PR to import @cody-clark // to check the rendering |
|
@chenopis Something weird is happening for the .yaml excerpt on line 192. It renders fine in the Github Preview and in my own Github Pages site, but becomes a codeblock paragraph in the Netlify preview. |
|
Try with 2, 4, 6, 8 spaces of indentation. One of them should work. I can update the commit if you find a solution. If it doesn't work we can revert back to HTML, or just destroy the numbered list. I promise I'll bring the tutorial contents back here soon so we don't have to go through this import dance again. |
|
@cody-clark Yeah, you might want to try 8 spaces. Also, check to see how many spaces are in front of Have I mentioned lately that I hate markdown? LOL |
|
@chenopis @ahmetb Any strong opinions against just deleting the excerpt? It doesn't really add to the documentation and it's blocking some important updates like working download links. Or we could merge this and fix the block when this repo is independent and trial and error checking is more forgiving. And I love that Markdown's consistently inconsistent :) It adds a new dimension to "no two days are the same." :') |
|
@cody-clark I suggest deleting the excerpt or just removing the "note:" callout field and leaving the text. |
|
It's a minor rendering issue I think we can fix separately after merging if no objections. |
|
@chenopis LGTM |
|
@ahmetb Ok, let's fix the md rending issue in a different PR. /lgtm |
|
@ahmetb Can you fix the merge conflict? |
Importing from kubernetes/examples repository. Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
|
Done |
* tutorials/guestbook: fix broken links Importing from kubernetes/examples repository. Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com> * Import newer versions for guestbook and cassandra Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
Importing from kubernetes/examples repository.
/assign @cody-clark
This change is