Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-3751 VolumeAttributeClass Beta Promotion #46785

Merged
merged 2 commits into from
Jul 29, 2024
Merged

KEP-3751 VolumeAttributeClass Beta Promotion #46785

merged 2 commits into from
Jul 29, 2024

Conversation

AndrewSirenko
Copy link
Contributor

@AndrewSirenko AndrewSirenko commented Jun 11, 2024 •
edited
Loading

@k8s-ci-robot k8s-ci-robot added this to the 1.31 milestone Jun 11, 2024
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 11, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @AndrewSirenko!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 11, 2024
@netlify Netlify
Copy link

netlify bot commented Jun 11, 2024 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 8c25433
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/66a79e9f41da5e0008ca4185

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jun 11, 2024
@AndrewSirenko AndrewSirenko mentioned this pull request Jun 11, 2024
Open
20 tasks
@netlify Netlify
Copy link

netlify bot commented Jun 11, 2024 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 8c25433
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66a79e9f96f30100082dfe0f
😎 Deploy Preview https://deploy-preview-46785--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dipesh-rawat
Copy link
Member

/sig storage

@k8s-ci-robot k8s-ci-robot added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Jun 12, 2024
dipesh-rawat
dipesh-rawat reviewed Jun 12, 2024
View reviewed changes
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial feedback on the draft PR's content:

  • Along with the changes in this current file it's essential we also update the VolumeAttributesClass feature gate description file volume-attributes-class.md (here) to include the new beta stage reflecting this promotion.
    Please refer the documentation (here) for guidance or refer to other feature gate files for assistance.

content/en/docs/concepts/storage/volume-attributes-classes.md Outdated Show resolved Hide resolved
@MaryamTavakkoli
Copy link
Contributor

Hello @AndrewSirenko 👋 Please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday July 16th 2024 18:00 PST. Thank you!

@Princesso
Copy link
Contributor

Hi @AndrewSirenko can you move this PR out of Draft, if it is ready for review. Thank you!

@Princesso
Copy link
Contributor

Hi @AndrewSirenko, a gentle reminder that tomorrow is the deadline for having your Docs PR ready for review. Please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before tomorrow, Tuesday, July 16th, 2024 18:00 PST.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/blog Issues or PRs related to the Kubernetes Blog subproject area/localization General issues or PRs related to localization language/bn Issues or PRs related to Bengali language language/es Issues or PRs related to Spanish language language/ja Issues or PRs related to Japanese language language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 15, 2024
@k8s-ci-robot k8s-ci-robot added area/localization General issues or PRs related to localization area/release-eng Issues or PRs related to the Release Engineering subproject area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes language/de Issues or PRs related to German language language/es Issues or PRs related to Spanish language language/hi Issues or PRs related to Hindi language language/ja Issues or PRs related to Japanese language language/pt Issues or PRs related to Portuguese language language/zh Issues or PRs related to Chinese language sig/release Categorizes an issue or PR as relevant to SIG Release. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 29, 2024
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 29, 2024
@AndrewSirenko
Copy link
Contributor Author

/unhold

The upstream changes have been merged in

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 29, 2024
@AndrewSirenko
Copy link
Contributor Author

Hi @Princesso, thanks for the check-in, all updates have now been made!

@xing-yang
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 29, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a1a0dc961e64eb01fca43370dfbfe1574a909c10

@natalisucks
Copy link
Contributor

We have LGTMs from SIG Docs reviewers as well as a tech review from SIG Storage, thanks everybody 👏
/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2024
@reylejano
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: natalisucks, reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 6c6ced2 into kubernetes:dev-1.31 Jul 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natalisucks natalisucks Awaiting requested review from natalisucks

@xing-yang xing-yang Awaiting requested review from xing-yang

@sftim sftim Awaiting requested review from sftim

@dipesh-rawat dipesh-rawat Awaiting requested review from dipesh-rawat

Assignees

@xing-yang xing-yang

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject area/localization General issues or PRs related to localization area/release-eng Issues or PRs related to the Release Engineering subproject area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/de Issues or PRs related to German language language/en Issues or PRs related to English language language/es Issues or PRs related to Spanish language language/hi Issues or PRs related to Hindi language language/ja Issues or PRs related to Japanese language language/pt Issues or PRs related to Portuguese language language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.31
Development

Successfully merging this pull request may close these issues.
9 participants
@AndrewSirenko @k8s-ci-robot @dipesh-rawat @MaryamTavakkoli @Princesso @xing-yang @sftim @natalisucks @reylejano