-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import guestbook tutorial and manifest files #4631
Conversation
@chenopis Is there a way to figure out why netlify preview has failed? |
/unassign |
@ahmetb It looks like it can't find the manifest files:
Could it be be because we're putting them in a new folder (/docs/tutorials/stateless-application/guestbook/)? The Cassandra example worked when we just left the manifest files in the same directory as the .md file (/docs/tutorials/stateful-application/). |
@cody-clark I think it's because of this:
it should be saying |
Deploy preview ready! Built with commit 3f20d3c https://deploy-preview-4631--kubernetes-io-master-staging.netlify.com |
Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
fixed now. |
It seems that liquid tags behave differently from code blocks so the numbering is still interrupted even if indented. I'll need to find a way maintain the numbering other than the {:start="#"} tag. Definition lists might be a solution. Also, I'll fix the prereq download links. |
We can merge and fix later. It seems like a low-priority problem to me. |
Agreed. |
@chenopis this is ready to review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
…hub.io into chenopis-user-journeys * 'master' of https://github.com/kubernetes/kubernetes.github.io: (40 commits) Update Jetstack logo Update index.md Update daemonset.md Update disruptions.md Update load-balance-access-application-cluster.md [404 fix] One character syntax fix (#4674) Logrotation for kubeadm (#4670) Patch PR #4671 Update scheduling-gpus.md Import guestbook tutorial and manifest files (#4631) Note on cascading deletes and Deployments (#4671) Fix Broken Link Create "make stage" for staging container Fix typo in extensible-admission-controllers doc (#4405) fix typo Update nodes.md Update encrypt-data.md Update managing-tls-in-a-cluster.md fix typo fix typo ...
Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
/assign @cody-clark please review the layout/rendering
This change is