Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import guestbook tutorial and manifest files #4631

Merged
merged 2 commits into from
Aug 7, 2017
Merged

Import guestbook tutorial and manifest files #4631

merged 2 commits into from
Aug 7, 2017

Conversation

ahmetb
Copy link
Member

@ahmetb ahmetb commented Aug 4, 2017

/assign @cody-clark please review the layout/rendering


This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 4, 2017
@ahmetb
Copy link
Member Author

ahmetb commented Aug 7, 2017

@chenopis Is there a way to figure out why netlify preview has failed?

@pwittrock
Copy link
Member

/unassign

@cody-clark
Copy link
Contributor

cody-clark commented Aug 7, 2017

@ahmetb It looks like it can't find the manifest files:

Error: Could not locate the included file 'redis-master-deployment.yaml' in any of ["/opt/build/repo/docs/tutorials/stateless-application"]. Ensure it exists in one of those directories and, if it is a symlink, does not point outside your site source.

Could it be be because we're putting them in a new folder (/docs/tutorials/stateless-application/guestbook/)? The Cassandra example worked when we just left the manifest files in the same directory as the .md file (/docs/tutorials/stateful-application/).

@ahmetb
Copy link
Member Author

ahmetb commented Aug 7, 2017

@cody-clark I think it's because of this:

{% include code.html language="yaml" file="redis-master-deployment.yaml"

it should be saying file="guestbook/redis-master-deployment.yaml". I'll fix.

@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Aug 7, 2017

Deploy preview ready!

Built with commit 3f20d3c

https://deploy-preview-4631--kubernetes-io-master-staging.netlify.com

Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
@ahmetb
Copy link
Member Author

ahmetb commented Aug 7, 2017

fixed now.

@cody-clark
Copy link
Contributor

It seems that liquid tags behave differently from code blocks so the numbering is still interrupted even if indented. I'll need to find a way maintain the numbering other than the {:start="#"} tag. Definition lists might be a solution.

Also, I'll fix the prereq download links.

@ahmetb
Copy link
Member Author

ahmetb commented Aug 7, 2017

We can merge and fix later. It seems like a low-priority problem to me.

@cody-clark cody-clark requested a review from chenopis August 7, 2017 22:19
@cody-clark
Copy link
Contributor

Agreed.

@ahmetb
Copy link
Member Author

ahmetb commented Aug 7, 2017

@chenopis this is ready to review.

Copy link
Contributor

@chenopis chenopis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@chenopis chenopis merged commit 3ee6599 into kubernetes:master Aug 7, 2017
chenopis added a commit that referenced this pull request Aug 8, 2017
…hub.io into chenopis-user-journeys

* 'master' of https://github.com/kubernetes/kubernetes.github.io: (40 commits)
  Update Jetstack logo
  Update index.md
  Update daemonset.md
  Update disruptions.md
  Update load-balance-access-application-cluster.md
  [404 fix] One character syntax fix (#4674)
  Logrotation for kubeadm (#4670)
  Patch PR #4671
  Update scheduling-gpus.md
  Import guestbook tutorial and manifest files (#4631)
  Note on cascading deletes and Deployments (#4671)
  Fix Broken Link
  Create "make stage" for staging container
  Fix typo in extensible-admission-controllers doc (#4405)
  fix typo
  Update nodes.md
  Update encrypt-data.md
  Update managing-tls-in-a-cluster.md
  fix typo
  fix typo
  ...
jesscodez pushed a commit that referenced this pull request Sep 22, 2017
Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants