-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Skew Docs to Fix Compatible Issues between Controller Clients and the API-Server #46109
base: main
Are you sure you want to change the base?
Update Skew Docs to Fix Compatible Issues between Controller Clients and the API-Server #46109
Conversation
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
/assign @liggitt |
I think we can mention in this doc that other components have their own skew requirements and their documentation should be consulted to determine what kube-apiserver versions they support and whether they should be upgraded before / after kube-apiserver. Separately, the aggregated API servers in various sig projects (metrics-server? custom-metrics-server?) should document their supported kube-apiserver versions. It looks like https://github.com/kubernetes-sigs/metrics-server?tab=readme-ov-file#compatibility-matrix and https://github.com/kubernetes-sigs/custom-metrics-apiserver?tab=readme-ov-file#compatibility need updates. |
Okay, Jordan.
The skew documentation contains kube-apiserver version requirements for each component. If there's another documentation, kindly let me know. |
This page documents supported skew of core kubernetes components. Mentioning in this doc that supported skew of other components should be considered might prompt admins to consider a category of compatibility that they are not considering today. Separately, the places where kubernetes sigs are documenting compatibility of aggregated API servers they release should be updated to be explicit about the supported kube-apiserver skew. Issues tracking this request in each repo and referencing this discussion would be a good start. Examples: |
That's true, I will add it.
https://github.com/kubernetes-sigs/metrics-server?tab=readme-ov-file#compatibility-matrix Great. |
Thanks. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
We prefer headings in sentence case
/remove-area release-eng
I recommend cancelling approval until the hold from #46109 (comment) is addressed. Then we can LGTM and re-approve. |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
@network-charles : Please may I know the latest on this? |
This pull request addresses an issue reported by a user regarding the compatibility of the aggregated apiserver library with Kubernetes v1.28 clusters. After updating to version v1.29 of the aggregated apiserver library, the user encountered failures on the Kubernetes v1.28 clusters, accompanied by the following errors:
Changes Made
References
kubernetes/kubernetes#124533
kubernetes/kubernetes#124655