Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-2258: Promote NodeLogQuery to beta #45126

Merged
merged 1 commit into from
Mar 15, 2024
Merged

KEP-2258: Promote NodeLogQuery to beta #45126

merged 1 commit into from
Mar 15, 2024

Conversation

aravindhp
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 13, 2024
@netlify Netlify
Copy link

netlify bot commented Feb 13, 2024 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 5a55277
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/65d6254d80815e00081cdb88

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 13, 2024
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Feb 13, 2024
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Feb 13, 2024
@aravindhp aravindhp mentioned this pull request Feb 13, 2024
Open
9 tasks
@reylejano
Copy link
Member

/milestone 1.30

@k8s-ci-robot k8s-ci-robot added this to the 1.30 milestone Feb 13, 2024
sftim
sftim requested changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

content/en/docs/concepts/cluster-administration/system-logs.md Outdated
@@ -293,4 +293,4 @@ kubectl get --raw "/api/v1/nodes/node-1.example/proxy/logs/?query=kubelet&patter
* Read about [Contextual Logging](https://github.com/kubernetes/enhancements/tree/master/keps/sig-instrumentation/3077-contextual-logging)
* Read about [deprecation of klog flags](https://github.com/kubernetes/enhancements/tree/master/keps/sig-instrumentation/2845-deprecate-klog-specific-flags-in-k8s-components)
* Read about the [Conventions for logging severity](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-instrumentation/logging.md)

* Read about [Log Query](https://github.com/kubernetes/enhancements/tree/master/keps/sig-windows/2258-node-log-query)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We link to https://kep.k8s.io/2256 instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you meant https://kep.k8s.io/2258. Fixed.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 14, 2024
aravindhp
aravindhp commented Feb 14, 2024
View reviewed changes
Copy link
Contributor Author

@aravindhp aravindhp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback, @sftim. I have addressed your comments to the best of my abilities. Please take a look.

content/en/docs/concepts/cluster-administration/system-logs.md Outdated
@@ -293,4 +293,4 @@ kubectl get --raw "/api/v1/nodes/node-1.example/proxy/logs/?query=kubelet&patter
* Read about [Contextual Logging](https://github.com/kubernetes/enhancements/tree/master/keps/sig-instrumentation/3077-contextual-logging)
* Read about [deprecation of klog flags](https://github.com/kubernetes/enhancements/tree/master/keps/sig-instrumentation/2845-deprecate-klog-specific-flags-in-k8s-components)
* Read about the [Conventions for logging severity](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-instrumentation/logging.md)

* Read about [Log Query](https://github.com/kubernetes/enhancements/tree/master/keps/sig-windows/2258-node-log-query)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you meant https://kep.k8s.io/2258. Fixed.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 20, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 21, 2024
@Princesso
Copy link
Contributor

Hello @aravindhp 👋 please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday March 12th 2024 18:00 PST. Thank you!

@aravindhp
Copy link
Contributor Author

@Princesso the PR is ready for review. Please let me know if I have missed something.

@aravindhp aravindhp mentioned this pull request Mar 13, 2024
Merged
@drewhagen
Copy link
Member

/sig windows

@k8s-ci-robot k8s-ci-robot added the sig/windows Categorizes an issue or PR as relevant to SIG Windows. label Mar 15, 2024
@drewhagen
Copy link
Member

drewhagen commented Mar 15, 2024 •
edited
Loading

Hello @aravindhp 👋, it looks like you've already engaged feedback in review of this PR. Great job! Keep this up. 🚀

@marosset @LiGgit @thockin @marosset
When one of y'all have a moment, please give a review for technical accuracy. A friendly reminder that this PR needs doc review complete by Doc Freeze on March 26th 18:00 PT to get this into the release.

@Princesso Please help review this also. Here is a markdown document on the KEP and the kep.yaml which has information useful for review. You can also check a preview of the documentation with Netlify above.

I appreciate everyone's help and so will our users! Thank you greatly.

@Princesso
Copy link
Contributor

/assign @sftim.

Hello Tim, can you give your final review on this PR?

Hello @p0lyn0mial 👋, a friendly reminder that this PR needs a doc review by March 26th 2024 18:00 PT to get this into the release. Please reach out to the required SIGs to get their review. Thank you!

sftim
sftim reviewed Mar 15, 2024
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 15, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: bf7f9bc3eca189941977ba16406ca495aec236a7

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 15, 2024
@k8s-ci-robot k8s-ci-robot merged commit b4e5f31 into kubernetes:dev-1.30 Mar 15, 2024
6 checks passed
@aravindhp aravindhp deleted the nlq-promote-beta branch March 15, 2024 17:53
@drewhagen
Copy link
Member

/milestone 1.30

@k8s-ci-robot k8s-ci-robot added this to the 1.30 milestone Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim requested changes

@44past4 44past4 Awaiting requested review from 44past4

@dims dims Awaiting requested review from dims

Assignees

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
[sig-windows] PR tracking
Status: Done
Milestone
1.30
Development

Successfully merging this pull request may close these issues.
6 participants
@aravindhp @reylejano @Princesso @drewhagen @k8s-ci-robot @sftim