Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KEP-2681] Docs update for Beta PodHostIPs #43448

Merged
merged 1 commit into from
Nov 27, 2023
Merged

[KEP-2681] Docs update for Beta PodHostIPs #43448

merged 1 commit into from
Nov 27, 2023

Conversation

wzshiming
Copy link
Member

@wzshiming wzshiming commented Oct 12, 2023 •
edited
Loading

@k8s-ci-robot k8s-ci-robot added this to the 1.29 milestone Oct 12, 2023
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 12, 2023
@netlify
Copy link

netlify bot commented Oct 12, 2023 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit fdf935b
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/655d5c28fad85d000839377f

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 12, 2023
@wzshiming wzshiming mentioned this pull request Oct 12, 2023
Closed
12 tasks
@harshitasao
Copy link
Contributor

Hi @wzshiming , Please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday 14th November 2023.
Thank you!

@k8s-ci-robot k8s-ci-robot added language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Nov 1, 2023
@wzshiming wzshiming changed the title [KEP-2681] Placeholder [KEP-2681] Docs update for Beta PodHostIPs Nov 1, 2023
@wzshiming wzshiming marked this pull request as ready for review November 1, 2023 01:59
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 1, 2023
@harshitasao
Copy link
Contributor

Hi, @wzshiming ! Kubernetes v1.29 Docs Shadow here. Just a reminder that the deadline to have this PR reviewed and merged is Tuesday, 28 November. Let me know if you need any help!

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Nov 22, 2023
@wzshiming
Copy link
Member Author

This PR is ready to review

/cc sig-docs-en-reviews

@tengqm
Copy link
Contributor

tengqm commented Nov 22, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 22, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7e11d4ecce92915918acd2021092fce590f6dc29

@katcosgrove
Copy link
Contributor

/assign @reylejano

@reylejano
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 27, 2023
@k8s-ci-robot k8s-ci-robot merged commit a3a4666 into kubernetes:dev-1.29 Nov 27, 2023
6 checks passed
@wzshiming wzshiming deleted the kep-2681 branch November 28, 2023 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kinzhi kinzhi Awaiting requested review from kinzhi

@tanjunchen tanjunchen Awaiting requested review from tanjunchen

Assignees

@tengqm tengqm

@reylejano reylejano

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.29
Development

Successfully merging this pull request may close these issues.
6 participants
@wzshiming @harshitasao @tengqm @k8s-ci-robot @katcosgrove @reylejano