New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove self-links with domain names in docs #4299

Merged

chenopis merged 20 commits into kubernetes:master from ahmetb:absfix

Jul 10, 2017

Member

ahmetb commented Jul 6, 2017 •

edited by k8s-reviewable

Loading

Fixes #4191. Skipping the tutorials we import from kubernetes/examples.
This helps with staging/migration tests better.

This change is


          Remove self-links with domain names in docs

2e36209

Fixes #4191. Skipping the tutorials we import from kubernetes/examples.

Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>

k8s-ci-robot added the cncf-cla: yes label

k8s-ci-robot assigned chenopis

chenopis suggested changes

View reviewed changes

Contributor

chenopis left a comment

Some of these links need to be updated to the current path.

docs/admin/federation/index.md Outdated

               `federation-apiserver` and a
-              [`PVC`](http://kubernetes.io/docs/user-guide/persistent-volumes/) backed
+              [`PVC`](/docs/user-guide/persistent-volumes/) backed

Contributor

chenopis Jul 6, 2017

This should be /docs/concepts/storage/persistent-volumes/

Contributor

chenopis Jul 10, 2017

done

docs/admin/federation/index.md Outdated

               by a dynamically provisioned
-              [`PV`](http://kubernetes.io/docs/user-guide/persistent-volumes/) for
+              [`PV`](/docs/user-guide/persistent-volumes/) for

Contributor

chenopis Jul 6, 2017

This should be /docs/concepts/storage/persistent-volumes/

Contributor

chenopis Jul 10, 2017

done

docs/admin/federation/index.md Outdated

@@ @@ -131,12 +131,12 @@ $ federation/deploy/deploy.sh deploy_federation @@
               This spins up the federation control components as pods managed by
               [`Deployments`](/docs/concepts/workloads/controllers/deployment/) on your
               existing Kubernetes cluster. It also starts a
-              [`type: LoadBalancer`](http://kubernetes.io/docs/user-guide/services/#type-loadbalancer)
-              [`Service`](http://kubernetes.io/docs/user-guide/services/) for the
+              [`type: LoadBalancer`](/docs/user-guide/services/#type-loadbalancer)

Contributor

chenopis Jul 6, 2017 •

edited

Loading

This should be /docs/concepts/services-networking/service/#type-loadbalancer

Contributor

chenopis Jul 10, 2017

done

docs/admin/federation/index.md Outdated

-              [`type: LoadBalancer`](http://kubernetes.io/docs/user-guide/services/#type-loadbalancer)
-              [`Service`](http://kubernetes.io/docs/user-guide/services/) for the
+              [`type: LoadBalancer`](/docs/user-guide/services/#type-loadbalancer)
+              [`Service`](/docs/user-guide/services/) for the

Contributor

chenopis Jul 6, 2017

This should be /docs/concepts/services-networking/service/

Contributor

chenopis Jul 10, 2017

done

docs/admin/federation/index.md Outdated

@@ @@ -247,7 +247,7 @@ federation, and @@
               in your federation DNS.
               You can find more details about config maps in general at
-              [config map](http://kubernetes.io/docs/user-guide/configmap/).
+              [config map](/docs/user-guide/configmap/).

Contributor

chenopis Jul 6, 2017

This should be /docs/tasks/configure-pod-container/configmap/

Contributor

chenopis Jul 10, 2017

done

docs/tools/kompose/user-guide.md Outdated

    
            @@ -284,7 +284,7 @@ Note:
          
              ## Alternate formats

              The default `kompose` transformation will generate Kubernetes [Deployments](/docs/concepts/workloads/controllers/deployment/) and [Services](http://kubernetes.io/docs/user-guide/services/), in yaml format. You have alternative option to generate json with `-j`. Also, you can alternatively generate [Replication Controllers](http://kubernetes.io/docs/user-guide/replication-controller/) objects, [Deamon Sets](http://kubernetes.io/docs/admin/daemons/), or [Helm](https://github.com/helm/helm) charts.

              The default `kompose` transformation will generate Kubernetes [Deployments](/docs/concepts/workloads/controllers/deployment/) and [Services](/docs/user-guide/services/), in yaml format. You have alternative option to generate json with `-j`. Also, you can alternatively generate [Replication Controllers](/docs/user-guide/replication-controller/) objects, [Deamon Sets](/docs/admin/daemons/), or [Helm](https://github.com/helm/helm) charts.

Contributor

chenopis Jul 6, 2017

Services -> /docs/concepts/services-networking/service/
Replication Controllers -> /docs/concepts/workloads/controllers/replicationcontroller/
typo: Daemon Sets -> /docs/concepts/workloads/controllers/daemonset/

Contributor

chenopis Jul 10, 2017

done

docs/tutorials/stateless-application/expose-external-ip-address.md Outdated

@@ @@ -12,7 +12,7 @@ external IP address. @@
               {% capture prerequisites %}
-               * Install [kubectl](http://kubernetes.io/docs/tasks/kubectl/install/).
+               * Install [kubectl](/docs/tasks/kubectl/install/).

Contributor

chenopis Jul 6, 2017

This should be /docs/tasks/tools/install-kubectl/

Contributor

chenopis Jul 10, 2017

done

docs/user-guide/configmap/README.md Outdated

@@ @@ -6,7 +6,7 @@ @@
               This example assumes you have a Kubernetes cluster installed and running, and that you have
               installed the `kubectl` command line tool somewhere in your path. Please see the [getting
-              started](http://kubernetes.io/docs/getting-started-guides/) for installation instructions for your platform.
+              started](/docs/getting-started-guides/) for installation instructions for your platform.

Contributor

chenopis Jul 6, 2017

This should be /docs/setup/pick-right-solution/

Contributor

chenopis Jul 10, 2017

done

docs/user-guide/downward-api/README.md Outdated

@@ @@ -1,11 +1,11 @@ @@
               Following these examples, you will create a pod with a container that consumes the pod's name,
-              namespace, and resource values using the [downward API](http://kubernetes.io/docs/user-guide/downward-api/).
+              namespace, and resource values using the [downward API](/docs/user-guide/downward-api/).

Contributor

chenopis Jul 6, 2017

This should be /docs/tasks/inject-data-application/downward-api-volume-expose-pod-information/

Contributor

chenopis Jul 10, 2017

done

docs/user-guide/downward-api/README.md Outdated

               ## Step Zero: Prerequisites
               This example assumes you have a Kubernetes cluster installed and running, and that you have
               installed the `kubectl` command line tool somewhere in your path. Please see the [getting
-              started](http://kubernetes.io/docs/getting-started-guides/) for installation instructions for your platform.
+              started](/docs/getting-started-guides/) for installation instructions for your platform.

Contributor

chenopis Jul 6, 2017

This should be /docs/setup/pick-right-solution/

Contributor

chenopis Jul 10, 2017

done

chenopis added the Docs Review: Open Issues label

Member Author

ahmetb commented Jul 8, 2017

@chenopis My intent in this PR is not to fix old links with the new links. (It's often good for a PR to fix only one thing.) It is to make sure while you're browsing the sandbox (on Netlify/localhost) you don't accidentally escape to live site.

If you think they must be fixed: a) feel free to take over the PR (you can commit to my fork/branch) or b) merge this and then submit a PR fixing the old links with new ones.

chenopis added 6 commits

July 10, 2017 14:49


          update federation/index.md user-guide links

8be9f1d


          update assign-pod-node.md links

ee59b75


          update dns-pod-service.md link

321bb9a


          update link in jobs-run-to-completion.md

81a16d6


          update link in minikube.md

279c762


          update PS link in minikube.md

fa4d666

Contributor

chenopis commented Jul 10, 2017

Deploy preview ready!

Built with commit 8be9f1d

https://deploy-preview-4299--kubernetes-io-master-staging.netlify.com


          update links in stackpoint.md

b4b4e37

Contributor

chenopis commented Jul 10, 2017

Deploy preview ready!

Built with commit fa4d666

https://deploy-preview-4299--kubernetes-io-master-staging.netlify.com

chenopis added 3 commits

July 10, 2017 14:57


          update links in storage.md

65067f1


          fix link in vsphere.md

0b2dce9


          fix links in deprecation-policy.md

4881e9f

Contributor

chenopis commented Jul 10, 2017

Deploy preview ready!

Built with commit b4b4e37

https://deploy-preview-4299--kubernetes-io-master-staging.netlify.com

chenopis added 2 commits

July 10, 2017 15:00


          Update pick-right-solution.md

a04d1e6


          Update web-ui-dashboard.md

35efb61

Contributor

chenopis commented Jul 10, 2017

Deploy preview ready!

Built with commit 4881e9f

https://deploy-preview-4299--kubernetes-io-master-staging.netlify.com

chenopis added 4 commits

July 10, 2017 15:02


          Update ingress.md

0b687ed


          Update federation-service-discovery.md

fd051f4


          Update user-guide.md

f834593


          Update expose-external-ip-address.md

379a1a9

Contributor

chenopis commented Jul 10, 2017

Deploy preview ready!

Built with commit 35efb61

https://deploy-preview-4299--kubernetes-io-master-staging.netlify.com

chenopis added 2 commits

July 10, 2017 15:06


          Update README.md

3e01f1a


          Update README.md

f55fd7c

Contributor

chenopis commented Jul 10, 2017

Deploy preview ready!

Built with commit 379a1a9

https://deploy-preview-4299--kubernetes-io-master-staging.netlify.com

chenopis approved these changes

View reviewed changes

Contributor

chenopis left a comment

Ok, I've updated the links.


          Merge branch 'master' into absfix

fe209b1

chenopis added Docs LGTM and removed Docs Review: Open Issues labels

Contributor

chenopis commented Jul 10, 2017

Deploy preview ready!

Built with commit f55fd7c

https://deploy-preview-4299--kubernetes-io-master-staging.netlify.com

Contributor

chenopis commented Jul 10, 2017

Deploy preview ready!

Built with commit fe209b1

https://deploy-preview-4299--kubernetes-io-master-staging.netlify.com

chenopis merged commit 0667180 into kubernetes:master

Member Author

ahmetb commented Jul 10, 2017

🙌

jesscodez pushed a commit that referenced this pull request


          Remove self-links with domain names in docs (#4299)

607bf52

* Remove self-links with domain names in docs

Fixes #4191. Skipping the tutorials we import from kubernetes/examples.

Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>

* update federation/index.md user-guide links

* update assign-pod-node.md links

* update dns-pod-service.md link

* update link in jobs-run-to-completion.md

* update link in minikube.md

* update PS link in minikube.md

* update links in stackpoint.md

* update links in storage.md

* fix link in vsphere.md

* fix links in deprecation-policy.md

* Update pick-right-solution.md

* Update web-ui-dashboard.md

* Update ingress.md

* Update federation-service-discovery.md

* Update user-guide.md

* Update expose-external-ip-address.md

* Update README.md

* Update README.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels