Copy-to-clipboard fix #4190
Merged
Copy-to-clipboard fix #4190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
target.setSelectionRange(0, target.value.length); does not always seem to be working. It doesn't work once the text is unselected. Using textarea.select() function: https://developer.mozilla.org/en-US/docs/Web/API/HTMLInputElement/select Fixes #3965. Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
2 tasks
|
I am seeing some weird stuff with github today. The source branches and the pull requests are not syncing commits when I update a commit with --amend and push with |
Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
k8s-ci-robot
added
the
cncf-cla: yes
|
Yeah, @gnufied mentioned a similar problem this morning. |
|
Looks like the commits are updated now. PTAL again. /assign @chenopis. |
|
Thank you for fixing this! |
chenopis
added a commit
that referenced
this pull request
Jun 26, 2017
…hub.io into release-1.7 * 'master' of https://github.com/kubernetes/kubernetes.github.io: /docs/samples revamp: move examples to /tutorials Copy-to-clipboard fix (#4190)
chenopis
added a commit
that referenced
this pull request
Jun 26, 2017
…hub.io into release-1.6 * 'master' of https://github.com/kubernetes/kubernetes.github.io: /docs/samples revamp: move examples to /tutorials Copy-to-clipboard fix (#4190)
chenopis
added a commit
to iphutch/kubernetes.github.io
that referenced
this pull request
Jun 26, 2017
…hub.io * 'master' of https://github.com/kubernetes/kubernetes.github.io: (76 commits) /docs/samples revamp: move examples to /tutorials Copy-to-clipboard fix (kubernetes#4190) Document kubeadm KUBELET_DNS_ARGS issue CronJobs aren't enabled in 1.6 by default Fix typo Document pod-template-hash label Rename last remaining reference of kargo to kubespray fixed loopback plugin link Document how to use custom certs with kubeadm (kubernetes#4113) Document product_uuid and MAC reqs fixed kubernetes#3968 (kubernetes#4105) Add documentation for ip-masq-agent. Update installation instructions with snap (kubernetes#4171) Update scratch.md: include download binary tarball (kubernetes#3933) Typo in authentication.md Fix broken links to client samples. (kubernetes#4139) Edits for clarity, concision, style, formatting, (kubernetes#4160) rename kargo to kubespray in getting started docs (kubernetes#4119) whatisk8s - Chinese version (kubernetes#3243) split rows and nest to stack columns (kubernetes#4129) ...
chenopis
added a commit
to megastef/kubernetes.github.io
that referenced
this pull request
Jun 26, 2017
…hub.io * 'master' of https://github.com/kubernetes/kubernetes.github.io: (1024 commits) /docs/samples revamp: move examples to /tutorials Copy-to-clipboard fix (kubernetes#4190) Document kubeadm KUBELET_DNS_ARGS issue CronJobs aren't enabled in 1.6 by default Fix typo Document pod-template-hash label Rename last remaining reference of kargo to kubespray fixed loopback plugin link Document how to use custom certs with kubeadm (kubernetes#4113) Document product_uuid and MAC reqs fixed kubernetes#3968 (kubernetes#4105) Add documentation for ip-masq-agent. Update installation instructions with snap (kubernetes#4171) Update scratch.md: include download binary tarball (kubernetes#3933) Typo in authentication.md Fix broken links to client samples. (kubernetes#4139) Edits for clarity, concision, style, formatting, (kubernetes#4160) rename kargo to kubespray in getting started docs (kubernetes#4119) whatisk8s - Chinese version (kubernetes#3243) split rows and nest to stack columns (kubernetes#4129) ... # Conflicts: # _data/tasks.yml
jesscodez
pushed a commit
that referenced
this pull request
Sep 22, 2017
* Copy-to-clipboard fix target.setSelectionRange(0, target.value.length); does not always seem to be working. It doesn't work once the text is unselected. Using textarea.select() function: https://developer.mozilla.org/en-US/docs/Web/API/HTMLInputElement/select Fixes #3965. Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com> * Empty commit Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
target.setSelectionRange(0, target.value.length); does not always seem to be
working. It doesn't work once the text is unselected. Using textarea.select()
function: https://developer.mozilla.org/en-US/docs/Web/API/HTMLInputElement/select
Signed-off-by: Ahmet Alp Balkan ahmetb@google.com
Fixes #3965.
This change is