Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy-to-clipboard fix #4190

Merged
merged 2 commits into from
Jun 26, 2017
Merged

Copy-to-clipboard fix #4190

merged 2 commits into from
Jun 26, 2017

Conversation

ahmetb
Copy link
Member

@ahmetb ahmetb commented Jun 26, 2017

target.setSelectionRange(0, target.value.length); does not always seem to be
working. It doesn't work once the text is unselected. Using textarea.select()
function: https://developer.mozilla.org/en-US/docs/Web/API/HTMLInputElement/select

Signed-off-by: Ahmet Alp Balkan ahmetb@google.com

Fixes #3965.


This change is Reviewable

@ahmetb ahmetb changed the title [WIP] Copy-to-clipboard fix Copy-to-clipboard fix Jun 26, 2017
target.setSelectionRange(0, target.value.length); does not always seem to be
working. It doesn't work once the text is unselected. Using textarea.select()
function: https://developer.mozilla.org/en-US/docs/Web/API/HTMLInputElement/select

Fixes #3965.

Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
@ahmetb
Copy link
Member Author

ahmetb commented Jun 26, 2017

I am seeing some weird stuff with github today. The source branches and the pull requests are not syncing commits when I update a commit with --amend and push with -f. Anyone else seeing this?

Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 26, 2017
@chenopis
Copy link
Contributor

Yeah, @gnufied mentioned a similar problem this morning.

@ahmetb
Copy link
Member Author

ahmetb commented Jun 26, 2017

Looks like the commits are updated now. PTAL again.

/assign @chenopis.

@chenopis chenopis merged commit d33222a into kubernetes:master Jun 26, 2017
@ryanmcginnis
Copy link
Contributor

Thank you for fixing this!

chenopis added a commit that referenced this pull request Jun 26, 2017
…hub.io into release-1.7

* 'master' of https://github.com/kubernetes/kubernetes.github.io:
  /docs/samples revamp: move examples to /tutorials
  Copy-to-clipboard fix (#4190)
chenopis added a commit that referenced this pull request Jun 26, 2017
…hub.io into release-1.6

* 'master' of https://github.com/kubernetes/kubernetes.github.io:
  /docs/samples revamp: move examples to /tutorials
  Copy-to-clipboard fix (#4190)
chenopis added a commit to iphutch/kubernetes.github.io that referenced this pull request Jun 26, 2017
…hub.io

* 'master' of https://github.com/kubernetes/kubernetes.github.io: (76 commits)
  /docs/samples revamp: move examples to /tutorials
  Copy-to-clipboard fix (kubernetes#4190)
  Document kubeadm KUBELET_DNS_ARGS issue
  CronJobs aren't enabled in 1.6 by default
  Fix typo
  Document pod-template-hash label
  Rename last remaining reference of kargo to kubespray
  fixed loopback plugin link
  Document how to use custom certs with kubeadm (kubernetes#4113)
  Document product_uuid and MAC reqs
  fixed kubernetes#3968 (kubernetes#4105)
  Add documentation for ip-masq-agent.
  Update installation instructions with snap (kubernetes#4171)
  Update scratch.md: include download binary tarball (kubernetes#3933)
  Typo in authentication.md
  Fix broken links to client samples. (kubernetes#4139)
  Edits for clarity, concision, style, formatting, (kubernetes#4160)
  rename kargo to kubespray in getting started docs (kubernetes#4119)
  whatisk8s - Chinese version (kubernetes#3243)
  split rows and nest to stack columns (kubernetes#4129)
  ...
chenopis added a commit to megastef/kubernetes.github.io that referenced this pull request Jun 26, 2017
…hub.io

* 'master' of https://github.com/kubernetes/kubernetes.github.io: (1024 commits)
  /docs/samples revamp: move examples to /tutorials
  Copy-to-clipboard fix (kubernetes#4190)
  Document kubeadm KUBELET_DNS_ARGS issue
  CronJobs aren't enabled in 1.6 by default
  Fix typo
  Document pod-template-hash label
  Rename last remaining reference of kargo to kubespray
  fixed loopback plugin link
  Document how to use custom certs with kubeadm (kubernetes#4113)
  Document product_uuid and MAC reqs
  fixed kubernetes#3968 (kubernetes#4105)
  Add documentation for ip-masq-agent.
  Update installation instructions with snap (kubernetes#4171)
  Update scratch.md: include download binary tarball (kubernetes#3933)
  Typo in authentication.md
  Fix broken links to client samples. (kubernetes#4139)
  Edits for clarity, concision, style, formatting, (kubernetes#4160)
  rename kargo to kubespray in getting started docs (kubernetes#4119)
  whatisk8s - Chinese version (kubernetes#3243)
  split rows and nest to stack columns (kubernetes#4129)
  ...

# Conflicts:
#	_data/tasks.yml
jesscodez pushed a commit that referenced this pull request Sep 22, 2017
* Copy-to-clipboard fix

target.setSelectionRange(0, target.value.length); does not always seem to be
working. It doesn't work once the text is unselected. Using textarea.select()
function: https://developer.mozilla.org/en-US/docs/Web/API/HTMLInputElement/select

Fixes #3965.

Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>

* Empty commit

Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants