Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add blog post about forensic container analysis #39759

Merged
merged 1 commit into from
Mar 8, 2023
Merged

Add blog post about forensic container analysis #39759

merged 1 commit into from
Mar 8, 2023

Conversation

adrianreber
Copy link
Contributor

This adds a blog article how to use to do forensic analysis on a container checkpoint.

kubernetes/enhancements#2008

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 2, 2023
@k8s-ci-robot k8s-ci-robot added area/blog Issues or PRs related to the Kubernetes Blog subproject language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Mar 2, 2023
@adrianreber adrianreber force-pushed the 2023-03-02-forensic branch from 81b58ae to db44b0f Compare March 2, 2023 18:22
@netlify
Copy link

netlify bot commented Mar 2, 2023 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit a45d7fe
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/64077f31048b110007b89304
😎 Deploy Preview https://deploy-preview-39759--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

sftim
sftim reviewed Mar 2, 2023
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some early feedback - hope it's useful

content/en/blog/_posts/2023-03-10-forensic-container-analysis/index.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-03-10-forensic-container-analysis/index.md Show resolved Hide resolved
content/en/blog/_posts/2023-03-10-forensic-container-analysis/index.md Show resolved Hide resolved
content/en/blog/_posts/2023-03-10-forensic-container-analysis/index.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-03-10-forensic-container-analysis/index.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-03-10-forensic-container-analysis/index.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-03-10-forensic-container-analysis/index.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-03-10-forensic-container-analysis/index.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-03-10-forensic-container-analysis/index.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-03-10-forensic-container-analysis/index.md Show resolved Hide resolved
@adrianreber adrianreber force-pushed the 2023-03-02-forensic branch 2 times, most recently from 99474d7 to ee75b86 Compare March 3, 2023 08:22
@adrianreber
Copy link
Contributor Author

Some early feedback - hope it's useful

Thanks. As always, very helpful.

@adrianreber adrianreber marked this pull request as ready for review March 3, 2023 08:25
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 3, 2023
@k8s-ci-robot k8s-ci-robot requested review from onlydole and sftim March 3, 2023 08:25
@adrianreber
Copy link
Contributor Author

@haircommander @saschagrunert please take a look, it is not as CRI-O related as the previous blog post, but as you also reviewed the previous blog post, maybe you also have some input for this PR. Thanks.

@haircommander
Copy link
Contributor

LGTM, interesting blog and seems useful!

sftim
sftim reviewed Mar 7, 2023
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks
/lgtm
/approve

/hold
as there is feedback available.

If you want to @adrianreber you can open another PR that updates your previous article to link to this follow up.
(/hold that other PR until this one publishes)

content/en/blog/_posts/2023-03-10-forensic-container-analysis/index.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 7, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 7, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ef1e118332e1639088b6fe2bd9a6bae96e1ff93c

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2023
@sftim
Copy link
Contributor

sftim commented Mar 7, 2023

@adrianreber you can unhold this PR right away, or you can do the wording tweak and get a new LGTM. Your choice.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 7, 2023
@k8s-ci-robot k8s-ci-robot requested a review from sftim March 7, 2023 18:12
@adrianreber @sftim
Add blog post about forensic container analysis
a45d7fe 
Co-authored-by: Tim Bannister <tim@scalefactory.com>
Signed-off-by: Adrian Reber <areber@redhat.com>
@adrianreber adrianreber force-pushed the 2023-03-02-forensic branch from 86a7634 to a45d7fe Compare March 7, 2023 18:15
@adrianreber
Copy link
Contributor Author

@adrianreber you can unhold this PR right away, or you can do the wording tweak and get a new LGTM. Your choice.

I added your suggestions and re-pushed.

@adrianreber adrianreber mentioned this pull request Mar 7, 2023
Merged
@adrianreber
Copy link
Contributor Author

If you want to @adrianreber you can open another PR that updates your previous article to link to this follow up.
(/hold that other PR until this one publishes)

#39842

saschagrunert
saschagrunert approved these changes Mar 8, 2023
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great blog post!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert, sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sftim
sftim reviewed Mar 8, 2023
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Mar 8, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b99a68973c44e709329129334e1f98302e6d945a

@k8s-ci-robot k8s-ci-robot merged commit ed7d4cc into kubernetes:main Mar 8, 2023
@adrianreber adrianreber mentioned this pull request Oct 19, 2023
Open
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@saschagrunert saschagrunert saschagrunert approved these changes

@nate-double-u nate-double-u Awaiting requested review from nate-double-u

@onlydole onlydole Awaiting requested review from onlydole

Assignees

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
SIG Docs Blog Project Board
Status: Published
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@adrianreber @haircommander @k8s-ci-robot @sftim @saschagrunert