Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs to reference container image registry registry.k8s.io #35715

Closed

Conversation

ameukam
Copy link
Member

@ameukam ameukam commented Aug 4, 2022

k8s.gcr.io is deprecated in favor of registry.k8s.io. The kubernetes
codebase have been updated with the new endpoint.

Ref: kubernetes/k8s.io#3411

Signed-off-by: Arnaud Meukam ameukam@gmail.com

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/release-eng Issues or PRs related to the Release Engineering subproject language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/release Categorizes an issue or PR as relevant to SIG Release. labels Aug 4, 2022
@ameukam
Copy link
Member Author

ameukam commented Aug 4, 2022

/kind deprecation
/kind cleanup
/sig k8s-infra

@k8s-ci-robot k8s-ci-robot added kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. labels Aug 4, 2022
@ameukam
Copy link
Member Author

ameukam commented Aug 4, 2022

cc @dims
/assign @jimangel @shannonxtreme

@netlify
Copy link

netlify bot commented Aug 4, 2022

Pull request preview available for checking

Name Link
🔨 Latest commit 251a78f
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/62ec49cbf0d9d40008386d50
😎 Deploy Preview https://deploy-preview-35715--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 4, 2022

Pull request preview available for checking

Name Link
🔨 Latest commit 348b100
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/62ec4b26a2317100081d3970
😎 Deploy Preview https://deploy-preview-35715--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sftim
Copy link
Contributor

sftim commented Aug 5, 2022

Should we do this switchover

  • on the day of the v1.25 release?
  • earlier?
  • later?

@ameukam
Copy link
Member Author

ameukam commented Aug 5, 2022

Should we do this switchover

  • on the day of the v1.25 release?
  • earlier?
  • later?

I would be interested to do it the day of the release but I think we need to talk to current release doc team.

@sftim
Copy link
Contributor

sftim commented Aug 5, 2022

I would be interested to do it the day of the release but I think we need to talk to current release doc team.

For that, check in with #release-comms / #release-docs on Kubernetes Slack. You would also target a different Git branch: dev-1.25.

We can backport this change to the docs for older releases; does that sound like a good idea?

@sftim
Copy link
Contributor

sftim commented Aug 5, 2022

/retitle Update docs to reference container image registry registry.k8s.io

@k8s-ci-robot k8s-ci-robot changed the title Migrate docs to registry.k8s.io Update docs to reference container image registry registry.k8s.io Aug 5, 2022
@reylejano
Copy link
Member

/milestone 1.25
/assign @kcmartin

@k8s-ci-robot k8s-ci-robot added this to the 1.25 milestone Aug 5, 2022
@ameukam ameukam changed the base branch from main to dev-1.25 August 5, 2022 13:04
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 5, 2022
@ameukam ameukam force-pushed the 1-25-migrate-registry-k8s-io branch from 348b100 to 416c624 Compare August 5, 2022 13:41
@netlify
Copy link

netlify bot commented Aug 5, 2022

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 416c624
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/62ed1e0937d7040009221cde

@k8s-ci-robot k8s-ci-robot added area/blog Issues or PRs related to the Kubernetes Blog subproject and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 5, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jimangel by writing /assign @jimangel in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added language/de Issues or PRs related to German language language/fr Issues or PRs related to French language language/id Issues or PRs related to Indonesian language language/it Issues or PRs related to Italian language language/ja Issues or PRs related to Japanese language language/pt Issues or PRs related to Portuguese language language/uk Issues or PRs related to Ukrainian language language/zh Issues or PRs related to Chinese language labels Aug 5, 2022
@Sea-n
Copy link
Member

Sea-n commented Aug 6, 2022

It seems wrong to have 83 rebased commits.

Hold until git issue solved.
/hold

@Sea-n
Copy link
Member

Sea-n commented Aug 9, 2022

Hey @ameukam,

It's been days since the last update, would you like to solve the git problem and move forward?

@ameukam
Copy link
Member Author

ameukam commented Aug 9, 2022

Hey @ameukam,

It's been days since the last update, would you like to solve the git problem and move forward?

Replaced by #35803.
/close

@k8s-ci-robot
Copy link
Contributor

@ameukam: Closed this PR.

In response to this:

Hey @ameukam,

It's been days since the last update, would you like to solve the git problem and move forward?

Replaced by #35803.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/blog Issues or PRs related to the Kubernetes Blog subproject area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. language/de Issues or PRs related to German language language/en Issues or PRs related to English language language/fr Issues or PRs related to French language language/id Issues or PRs related to Indonesian language language/it Issues or PRs related to Italian language language/ja Issues or PRs related to Japanese language language/pt Issues or PRs related to Portuguese language language/uk Issues or PRs related to Ukrainian language language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.