-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for container checkpointing feature (KEP 2008) #34940
Add documentation for container checkpointing feature (KEP 2008) #34940
Conversation
👷 Deploy Preview for kubernetes-io-vnext-staging processing.
|
CC: @mikebrow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on:
TODO: Add more information about return codes once CRI implementation have checkpoint/restore.
/retitle [WIP] Add documentation for container checkpointing feature (KEP 2008)
We will not be able to fix this TODO before the release. Without the release the new CRI API is not available and cannot be implemented by the CRI implementation. This TODO can only be fixed after the release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This reads really well. I was hoping you could add a bit more in your return codes comment.
af02da6
to
3a563bd
Compare
3a563bd
to
3b992d3
Compare
Co-authored-by: Tim Bannister <tim@scalefactory.com> Signed-off-by: Adrian Reber <areber@redhat.com>
3b992d3
to
df55ed5
Compare
/remove-language ko zh |
@adrianreber , when this PR is ready for review, please remove [WIP] from the title |
{{< comment >}} | ||
TODO: Add more information about return codes once CRI implementation have checkpoint/restore. | ||
This TODO cannot be fixed before the release, because the CRI implementation need | ||
the Kubernetes changes to be merged to implement the new CheckpointContainer CRI API | ||
call. We need to wait after the 1.25 release to fix this. | ||
{{< /comment >}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest removing this section and create a GitHub issue to track this
{{< comment >}} | |
TODO: Add more information about return codes once CRI implementation have checkpoint/restore. | |
This TODO cannot be fixed before the release, because the CRI implementation need | |
the Kubernetes changes to be merged to implement the new CheckpointContainer CRI API | |
call. We need to wait after the 1.25 release to fix this. | |
{{< /comment >}} |
Hi @adrianreber , the 1.25 Docs complete deadline passed. |
I can address my comment in a follow-up PR |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: reylejano The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
LGTM label has been added. Git tree hash: a32cde75059bab4efaa4add4cd2d680f9d976f47
|
Sorry. I was away for some time and not able to react in a timely manner. I can do any fixup needed if you let me know what you would like to have changed. |
Pull request for KEP 2008:
CC: @sftim (you reviewed my previous 1.24 attempt of this documentation PR)